Skip to content

Commit 0823a9d

Browse files
committed
docs: make enforce_admins flip required in exit checklist (#93 review)
Code review on #101 pushed back on step 4 of the "When the exemption ends" checklist: "Optionally flip enforce_admins to true". Leaving it false in a 2-person setup keeps the admin-bypass door open even after the single-owner workaround is no longer needed — which defeats the point of having an exit checklist. Drops "Optionally" and adds a one-line rationale so a future reader understands why the flip is non-optional. Refs #93
1 parent 70b96dd commit 0823a9d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ gh pr merge <N> --admin --squash --delete-branch
6060
1. Drop the `--admin` flag from the merge command and adopt standard PR review.
6161
2. Remove this entire subsection.
6262
3. Update `CODEOWNERS` to add the new collaborator.
63-
4. Optionally flip `enforce_admins` to `true` in the branch-protection JSON for both branches.
63+
4. Flip `enforce_admins` to `true` in the branch-protection JSON for both branches. Leaving it `false` would keep the admin-bypass door open even after the single-owner workaround is no longer needed — defeats the point of removing the workaround.
6464

6565
All four changes land in a single PR.
6666

0 commit comments

Comments
 (0)