refactor generate.ts: remove infrastructure concerns, add functions-registry configmap

generate.ts was mixing function scaffolding with infrastructure config,
regenerating the entire job-service.yaml and kustomize overlays just to
set 3 env vars. This made the manifest uneditable and added ~200 lines
of string-based YAML construction.

Changes:
- Remove generateJobServiceYaml() — job-service.yaml is now hand-written
  and reads function data from a generated functions-registry ConfigMap
- Replace generateJobServicePatch() with generateFunctionsConfigMap() —
  writes a simple ConfigMap instead of kustomize overlay machinery
- Move shared template files (tsconfig, README) to templates/shared/
- Remove hardcoded SIMPLE_EMAIL_DRY_RUN/SEND_EMAIL_LINK_DRY_RUN from
  local-deployment template, moved to constructive ConfigMap
- Add port validation (duplicate ports, reserved port 8080)
- Fix fragile indexOf lookup with proper index-based iteration
- Update package.json engines to >=22.0.0 (required for --experimental-strip-types)

Author: Anmol1696

k8s/overlays/local-simple/config.yaml

@@ -21,3 +21,6 @@ data:
   API_DEFAULT_DATABASE_ID: "constructive"
 
   LOG_TIMESTAMP: "true"
+
+  SIMPLE_EMAIL_DRY_RUN: "true"
+  SEND_EMAIL_LINK_DRY_RUN: "true"

k8s/overlays/local-simple/job-service.yaml

@@ -1,5 +1,3 @@
-# AUTO-GENERATED by scripts/generate.ts — do not edit manually.
-# To add a function, create functions/<name>/handler.json and run `pnpm generate`.
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -24,6 +22,8 @@ spec:
           envFrom:
             - configMapRef:
                 name: constructive
+            - configMapRef:
+                name: functions-registry
             - secretRef:
                 name: pg-credentials
           env:
@@ -37,18 +37,12 @@ spec:
               value: "http://knative-job-service.constructive-functions.svc.cluster.local:8080"
             - name: JOBS_SUPPORT_ANY
               value: "false"
-            - name: JOBS_SUPPORTED
-              value: "knative-job-example,send-email-link,simple-email"
             - name: JOBS_CALLBACK_HOST
               value: "knative-job-service.constructive-functions.svc.cluster.local"
             - name: JOBS_CALLBACK_BASE_URL
               value: "http://knative-job-service.constructive-functions.svc.cluster.local:8080/callback"
             - name: KNATIVE_SERVICE_URL
               value: "constructive-functions.svc.cluster.local"
-            - name: INTERNAL_GATEWAY_URL
-              value: "http://knative-job-example.constructive-functions.svc.cluster.local"
-            - name: INTERNAL_GATEWAY_DEVELOPMENT_MAP
-              value: '{"knative-job-example":"http://knative-job-example.constructive-functions.svc.cluster.local","send-email-link":"http://send-email-link.constructive-functions.svc.cluster.local","simple-email":"http://simple-email.constructive-functions.svc.cluster.local"}'
             - name: HOSTNAME
               valueFrom:
                 fieldRef:

k8s/overlays/local-simple/kustomization.yaml

@@ -12,6 +12,8 @@ resources:
   - ./pg-secret.yaml
   - ./mailgun-secret.yaml
   - ./server-bucket-secret.yaml
+  # Functions registry (generated by pnpm generate)
+  - ../../../generated/functions-configmap.yaml
   # Constructive servers + db setup
   - ./constructive-server.yaml
   - ./constructive-server-admin.yaml

package.json

@@ -12,7 +12,7 @@
     "access": "restricted"
   },
   "engines": {
-    "node": ">=18.17.0"
+    "node": ">=22.0.0"
   },
   "packageManager": "pnpm@10.12.2",
   "scripts": {

scripts/generate.ts

@@ -12,6 +12,7 @@ const ROOT: string = process.cwd();
 const FUNCTIONS_DIR: string = path.resolve(ROOT, 'functions');
 const GENERATED_DIR: string = path.resolve(ROOT, 'generated');
 const TEMPLATES_DIR: string = path.resolve(ROOT, 'templates');
+const SHARED_TEMPLATES_DIR: string = path.resolve(TEMPLATES_DIR, 'shared');
 
 const DEFAULT_TEMPLATE = 'node-graphql';
 
@@ -172,7 +173,7 @@ function ensureSymlink(target: string, linkPath: string): boolean {
   return true;
 }
 
-// --- Skaffold & kustomize overlay generation ---
+// --- Skaffold & ConfigMap generation ---
 
 const K8S_NAMESPACE = 'constructive-functions';
 
@@ -182,47 +183,33 @@ interface FunctionInfo {
   port: number;
 }
 
-function generateJobServicePatch(fn: FunctionInfo): void {
-  const overlayDir = path.join(GENERATED_DIR, fn.dir, 'k8s', 'skaffold-overlay');
-  if (!fs.existsSync(overlayDir)) {
-    fs.mkdirSync(overlayDir, { recursive: true });
-  }
-
+function generateFunctionsConfigMap(fns: FunctionInfo[], perFunction?: FunctionInfo): void {
+  const targetFns = perFunction ? [perFunction] : fns;
+  const jobsSupported = targetFns.map((fn) => fn.name).join(',');
   const gatewayMap: Record<string, string> = {};
-  gatewayMap[fn.name] = `http://${fn.name}.${K8S_NAMESPACE}.svc.cluster.local`;
-
-  const kustomization = [
-    'apiVersion: kustomize.config.k8s.io/v1beta1',
-    'kind: Kustomization',
-    'resources:',
-    '  - ../../../../k8s/overlays/local-simple',
-    'patches:',
-    '  - path: job-service-patch.yaml',
-    '',
-  ].join('\n');
+  for (const fn of targetFns) {
+    gatewayMap[fn.name] = `http://${fn.name}.${K8S_NAMESPACE}.svc.cluster.local`;
+  }
 
-  const patch = [
-    'apiVersion: apps/v1',
-    'kind: Deployment',
+  const yaml = [
+    '# AUTO-GENERATED by scripts/generate.ts — do not edit manually.',
+    'apiVersion: v1',
+    'kind: ConfigMap',
     'metadata:',
-    '  name: knative-job-service',
-    'spec:',
-    '  template:',
-    '    spec:',
-    '      containers:',
-    '        - name: knative-job-service',
-    '          env:',
-    '            - name: JOBS_SUPPORTED',
-    `              value: "${fn.name}"`,
-    '            - name: INTERNAL_GATEWAY_URL',
-    `              value: "http://${fn.name}.${K8S_NAMESPACE}.svc.cluster.local"`,
-    '            - name: INTERNAL_GATEWAY_DEVELOPMENT_MAP',
-    `              value: '${JSON.stringify(gatewayMap)}'`,
+    '  name: functions-registry',
+    'data:',
+    `  JOBS_SUPPORTED: "${jobsSupported}"`,
+    `  INTERNAL_GATEWAY_DEVELOPMENT_MAP: '${JSON.stringify(gatewayMap)}'`,
     '',
   ].join('\n');
 
-  writeIfChanged(path.join(overlayDir, 'kustomization.yaml'), kustomization);
-  writeIfChanged(path.join(overlayDir, 'job-service-patch.yaml'), patch);
+  if (perFunction) {
+    const dir = path.join(GENERATED_DIR, perFunction.dir, 'k8s');
+    if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
+    writeIfChanged(path.join(dir, 'functions-configmap.yaml'), yaml);
+  } else {
+    writeIfChanged(path.join(GENERATED_DIR, 'functions-configmap.yaml'), yaml);
+  }
 }
 
 function generateSkaffoldYaml(fns: FunctionInfo[]): void {
@@ -268,9 +255,10 @@ function generateSkaffoldYaml(fns: FunctionInfo[]): void {
       '    manifests:',
       '      kustomize:',
       '        paths:',
-      `          - generated/${fn.dir}/k8s/skaffold-overlay`,
+      '          - k8s/overlays/local-simple',
       '      rawYaml:',
       `        - generated/${fn.dir}/k8s/local-deployment.yaml`,
+      `        - generated/${fn.dir}/k8s/functions-configmap.yaml`,
       '    deploy:',
       '      kubectl:',
       `        defaultNamespace: ${K8S_NAMESPACE}`,
@@ -308,6 +296,7 @@ function generateSkaffoldYaml(fns: FunctionInfo[]): void {
     '          - k8s/overlays/local-simple',
     '      rawYaml:',
     allRawYaml,
+    '        - generated/functions-configmap.yaml',
     '    deploy:',
     '      kubectl:',
     `        defaultNamespace: ${K8S_NAMESPACE}`,
@@ -354,103 +343,6 @@ function generateSkaffoldYaml(fns: FunctionInfo[]): void {
   }
 }
 
-function generateJobServiceYaml(fns: FunctionInfo[]): void {
-  const jobsSupported = fns.map((fn) => fn.name).join(',');
-  const gatewayMap: Record<string, string> = {};
-  for (const fn of fns) {
-    gatewayMap[fn.name] = `http://${fn.name}.${K8S_NAMESPACE}.svc.cluster.local`;
-  }
-
-  const yaml = [
-    '# AUTO-GENERATED by scripts/generate.ts — do not edit manually.',
-    '# To add a function, create functions/<name>/handler.json and run `pnpm generate`.',
-    'apiVersion: apps/v1',
-    'kind: Deployment',
-    'metadata:',
-    '  name: knative-job-service',
-    '  labels:',
-    '    app: knative-job-service',
-    'spec:',
-    '  replicas: 1',
-    '  selector:',
-    '    matchLabels:',
-    '      app: knative-job-service',
-    '  template:',
-    '    metadata:',
-    '      labels:',
-    '        app: knative-job-service',
-    '    spec:',
-    '      containers:',
-    '        - name: knative-job-service',
-    '          image: constructive-functions:local',
-    '          command: ["node"]',
-    '          args: ["job/service/dist/run.js"]',
-    '          envFrom:',
-    '            - configMapRef:',
-    '                name: constructive',
-    '            - secretRef:',
-    '                name: pg-credentials',
-    '          env:',
-    '            - name: NODE_ENV',
-    '              value: "development"',
-    '            - name: JOBS_SCHEMA',
-    '              value: "app_jobs"',
-    '            - name: INTERNAL_JOBS_CALLBACK_PORT',
-    '              value: "8080"',
-    '            - name: INTERNAL_JOBS_CALLBACK_URL',
-    `              value: "http://knative-job-service.${K8S_NAMESPACE}.svc.cluster.local:8080"`,
-    '            - name: JOBS_SUPPORT_ANY',
-    '              value: "false"',
-    '            - name: JOBS_SUPPORTED',
-    `              value: "${jobsSupported}"`,
-    '            - name: JOBS_CALLBACK_HOST',
-    `              value: "knative-job-service.${K8S_NAMESPACE}.svc.cluster.local"`,
-    '            - name: JOBS_CALLBACK_BASE_URL',
-    `              value: "http://knative-job-service.${K8S_NAMESPACE}.svc.cluster.local:8080/callback"`,
-    '            - name: KNATIVE_SERVICE_URL',
-    `              value: "${K8S_NAMESPACE}.svc.cluster.local"`,
-    '            - name: INTERNAL_GATEWAY_URL',
-    `              value: "http://${fns.map((fn) => fn.name).sort()[0] || 'unknown'}.${K8S_NAMESPACE}.svc.cluster.local"`,
-    '            - name: INTERNAL_GATEWAY_DEVELOPMENT_MAP',
-    `              value: '${JSON.stringify(gatewayMap)}'`,
-    '            - name: HOSTNAME',
-    '              valueFrom:',
-    '                fieldRef:',
-    '                  fieldPath: metadata.name',
-    '          ports:',
-    '            - containerPort: 8080',
-    '              name: jobs-http',
-    '          resources:',
-    '            requests:',
-    '              memory: "128Mi"',
-    '              cpu: "100m"',
-    '            limits:',
-    '              memory: "512Mi"',
-    '              cpu: "500m"',
-    '---',
-    'apiVersion: v1',
-    'kind: Service',
-    'metadata:',
-    '  name: knative-job-service',
-    '  labels:',
-    '    app: knative-job-service',
-    'spec:',
-    '  type: ClusterIP',
-    '  selector:',
-    '    app: knative-job-service',
-    '  ports:',
-    '    - name: jobs-http',
-    '      port: 8080',
-    '      targetPort: jobs-http',
-    '',
-  ].join('\n');
-
-  const jobServicePath = path.join(ROOT, 'k8s', 'overlays', 'local-simple', 'job-service.yaml');
-  if (writeIfChanged(jobServicePath, yaml)) {
-    console.log('  Updated k8s/overlays/local-simple/job-service.yaml');
-  }
-}
-
 // --- Main ---
 
 function main(): void {
@@ -498,6 +390,26 @@ function main(): void {
       if (changed) console.log(`    - ${relPath}`);
     }
 
+    // Process shared templates (files that don't vary by template type)
+    if (fs.existsSync(SHARED_TEMPLATES_DIR)) {
+      const sharedFiles = walkTemplateFiles(SHARED_TEMPLATES_DIR);
+      for (const relPath of sharedFiles) {
+        const templateFile = path.join(SHARED_TEMPLATES_DIR, relPath);
+        const outputFile = path.join(genDir, relPath);
+
+        const outputDir = path.dirname(outputFile);
+        if (!fs.existsSync(outputDir)) {
+          fs.mkdirSync(outputDir, { recursive: true });
+        }
+
+        const templateContent = fs.readFileSync(templateFile, 'utf-8');
+        const baseName = path.basename(relPath);
+        const processed = processTemplateFile(baseName, templateContent, manifest, fnDir);
+        const changed = writeIfChanged(outputFile, processed);
+        if (changed) console.log(`    - ${relPath} (shared)`);
+      }
+    }
+
     // Symlink handler.ts
     const handlerTarget = path.join(fnDir, 'handler.ts');
     if (fs.existsSync(handlerTarget)) {
@@ -542,11 +454,23 @@ function main(): void {
     }
   }
 
+  // Validate no duplicate ports
+  const portToFunction = new Map<number, string>();
+  for (const m of allManifests) {
+    if (m.port === 8080) {
+      throw new Error(`Function "${m.name}" uses port 8080 which is reserved for job-service.`);
+    }
+    if (portToFunction.has(m.port!)) {
+      throw new Error(`Port ${m.port} conflict: "${m.name}" and "${portToFunction.get(m.port!)}".`);
+    }
+    portToFunction.set(m.port!, m.name);
+  }
+
   const manifestData = {
-    functions: allManifests.map((m) => ({
-      name: m.name,
-      dir: functions[allManifests.indexOf(m)],
-      port: m.port,
+    functions: functions.map((dir, i) => ({
+      name: allManifests[i].name,
+      dir,
+      port: allManifests[i].port,
     })),
   };
 
@@ -556,18 +480,20 @@ function main(): void {
     console.log('  Updated generated/functions-manifest.json');
   }
 
-  // --- Generate skaffold, kustomize overlays, and job-service config ---
+  // --- Generate skaffold and functions-registry configmaps ---
   // Only when generating all functions (not --only mode)
   if (!onlyName) {
     const fnInfos: FunctionInfo[] = manifestData.functions as FunctionInfo[];
 
+    // Generate per-function configmaps (for single-function Skaffold profiles)
     for (const fn of fnInfos) {
-      generateJobServicePatch(fn);
+      generateFunctionsConfigMap(fnInfos, fn);
     }
-    console.log('  Generated per-function kustomize overlays');
+    // Generate aggregate configmap (for local-simple profile)
+    generateFunctionsConfigMap(fnInfos);
+    console.log('  Generated functions-registry configmaps');
 
     generateSkaffoldYaml(fnInfos);
-    generateJobServiceYaml(fnInfos);
   }
 
   console.log('Done.');

skaffold.yaml

@@ -23,9 +23,10 @@ profiles:
     manifests:
       kustomize:
         paths:
-          - generated/example/k8s/skaffold-overlay
+          - k8s/overlays/local-simple
       rawYaml:
         - generated/example/k8s/local-deployment.yaml
+        - generated/example/k8s/functions-configmap.yaml
     deploy:
       kubectl:
         defaultNamespace: constructive-functions
@@ -66,9 +67,10 @@ profiles:
     manifests:
       kustomize:
         paths:
-          - generated/send-email-link/k8s/skaffold-overlay
+          - k8s/overlays/local-simple
       rawYaml:
         - generated/send-email-link/k8s/local-deployment.yaml
+        - generated/send-email-link/k8s/functions-configmap.yaml
     deploy:
       kubectl:
         defaultNamespace: constructive-functions
@@ -109,9 +111,10 @@ profiles:
     manifests:
       kustomize:
         paths:
-          - generated/simple-email/k8s/skaffold-overlay
+          - k8s/overlays/local-simple
       rawYaml:
         - generated/simple-email/k8s/local-deployment.yaml
+        - generated/simple-email/k8s/functions-configmap.yaml
     deploy:
       kubectl:
         defaultNamespace: constructive-functions
@@ -159,6 +162,7 @@ profiles:
         - generated/example/k8s/local-deployment.yaml
         - generated/send-email-link/k8s/local-deployment.yaml
         - generated/simple-email/k8s/local-deployment.yaml
+        - generated/functions-configmap.yaml
     deploy:
       kubectl:
         defaultNamespace: constructive-functions