Skip to content

Commit 2872096

Browse files
committed
fix: remove anti-pattern of re-exporting third-party types from barrel
Remove S3Client and S3ClientConfig re-exports from s3-utils barrel. Consumers should import these directly from @aws-sdk/client-s3. Updated s3-streamer to import S3Client type from @aws-sdk/client-s3.
1 parent cf436df commit 2872096

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

uploads/s3-streamer/src/s3.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { createS3Client, S3Client } from '@constructive-io/s3-utils';
1+
import { createS3Client } from '@constructive-io/s3-utils';
22
import type { StorageProvider } from '@constructive-io/s3-utils';
3+
import type { S3Client } from '@aws-sdk/client-s3';
34
import type { BucketProvider } from '@pgpmjs/types';
45

56
interface S3Options {

uploads/s3-utils/src/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,3 @@ export * from './client';
22
export * from './policies';
33
export * from './presigned';
44
export * from './utils';
5-
6-
// Re-export S3Client so consumers don't need @aws-sdk/client-s3 directly
7-
export { S3Client } from '@aws-sdk/client-s3';
8-
export type { S3ClientConfig } from '@aws-sdk/client-s3';

0 commit comments

Comments
 (0)