Merge pull request #1154 from constructive-io/fix/remove-findmany-never-default

fix(types): remove = never default from FindManyArgs TOrderBy param

Author: pyramation

graphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap

@@ -386,7 +386,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

graphql/codegen/src/__tests__/codegen/react-query-hooks.test.ts

@@ -337,10 +337,8 @@ describe('Query Hook Generators', () => {
 });
 
 describe('Regression: FindManyArgs TCondition type arg', () => {
-  // Bug: queries.ts passed 3 type args to FindManyArgs (TSelect, TWhere, TOrderBy),
-  // but the template defines 4 params: FindManyArgs<TSelect, TWhere, TCondition = never, TOrderBy = never>.
-  // This caused TOrderBy to land in the TCondition slot, defaulting TOrderBy to `never`
-  // and breaking all hook orderBy params.
+  // Regression guard: queries.ts passes 3 type args to FindManyArgs (TSelect, TWhere, TOrderBy).
+  // A prior bug had 4 params with defaults, causing TOrderBy to land in the wrong slot.
 
   it('does not include Condition type in generated hooks', () => {
     const result = generateListQueryHook(simpleUserTable, {

graphql/codegen/src/core/codegen/templates/select-types.ts

@@ -21,7 +21,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-cli/src/admin/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-cli/src/auth/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-cli/src/objects/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-cli/src/public/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-react/src/admin/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-react/src/auth/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

sdk/constructive-react/src/objects/orm/select-types.ts

@@ -16,7 +16,7 @@ export interface PageInfo {
   endCursor?: string | null;
 }
 
-export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];