refactor: allow custom SMS provider names

Author: Zetazzz

graphql/env/__tests__/merge.test.ts

@@ -161,6 +161,14 @@ describe('getEnvOptions', () => {
     });
   });
 
+  it('accepts custom SMS provider names', () => {
+    const result = getGraphQLEnvVars({
+      SMS_PROVIDER: 'custom-sms-gateway'
+    });
+
+    expect(result.sms?.provider).toBe('custom-sms-gateway');
+  });
+
   it('honors defaults, config, env, and runtime override priority for SMS', () => {
     tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'graphql-env-sms-'));
     writeConfig(tempDir, {

graphql/env/src/env.ts

@@ -1,4 +1,4 @@
-import type { ConstructiveOptions, SmsProviderName } from '@constructive-io/graphql-types';
+import type { ConstructiveOptions } from '@constructive-io/graphql-types';
 
 /**
  * Parse GraphQL-related environment variables.
@@ -22,14 +22,6 @@ const parseEnvInteger = (name: string, val?: string): number | undefined => {
   return parsed;
 };
 
-const parseSmsProvider = (val?: string): SmsProviderName | undefined => {
-  if (val === undefined) return undefined;
-  if (val === 'devsms' || val === 'twilio' || val === 'sns') {
-    return val;
-  }
-  throw new Error('SMS_PROVIDER must be one of: devsms, twilio, sns');
-};
-
 /**
  * @param env - Environment object to read from (defaults to process.env for backwards compatibility)
  */
@@ -105,7 +97,7 @@ export const getGraphQLEnvVars = (env: NodeJS.ProcessEnv = process.env): Partial
     }),
     ...((SMS_PROVIDER || SMS_SENDER_ID || SMS_REQUEST_TIMEOUT_MS || SEND_SMS_DRY_RUN || DEVSMS_BASE_URL) && {
       sms: {
-        ...(SMS_PROVIDER && { provider: parseSmsProvider(SMS_PROVIDER) }),
+        ...(SMS_PROVIDER && { provider: SMS_PROVIDER }),
         ...(SMS_SENDER_ID && { senderId: SMS_SENDER_ID }),
         ...(SMS_REQUEST_TIMEOUT_MS && {
           requestTimeoutMs: parseEnvInteger('SMS_REQUEST_TIMEOUT_MS', SMS_REQUEST_TIMEOUT_MS)

graphql/env/src/index.ts

@@ -1,4 +1,4 @@
 // Export Constructive-specific env functions
 export { getEnvOptions, getConstructiveEnvOptions } from './merge';
 export { getGraphQLEnvVars } from './env';
-export type { DevSmsOptions, SmsOptions, SmsProviderName } from '@constructive-io/graphql-types';
+export type { DevSmsOptions, SmsOptions } from '@constructive-io/graphql-types';

graphql/types/src/index.ts

@@ -32,7 +32,6 @@ export {
 
 // Export SMS types
 export {
-  SmsProviderName,
   SmsOptions,
   DevSmsOptions,
   smsDefaults

graphql/types/src/sms.ts

@@ -5,16 +5,14 @@
  * packages decide which providers they implement and validate that required
  * provider-specific values are present before sending.
  */
-export type SmsProviderName = 'devsms' | 'twilio' | 'sns';
-
 export interface DevSmsOptions {
   /** Base URL for the local DevSms API, e.g. http://localhost:4000 */
   baseUrl?: string;
 }
 
 export interface SmsOptions {
-  /** SMS provider implementation to use. */
-  provider?: SmsProviderName;
+  /** SMS provider implementation to use; runtimes may register custom names. */
+  provider?: string;
   /** Optional sender ID/default source address for providers that support it. */
   senderId?: string;
   /** Outbound provider HTTP timeout in milliseconds. */