Merge pull request #1034 from constructive-io/feat/upload-dedup-status

feat: add status field to RequestUploadUrlPayload

Author: pyramation

graphile/graphile-presigned-url-plugin/src/plugin.ts

@@ -175,6 +175,8 @@ export function createPresignedUrlPlugin(
         deduplicated: Boolean!
         """Presigned URL expiry time (null if deduplicated)"""
         expiresAt: Datetime
+        """File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files. Clients can use this to know immediately whether the file is usable."""
+        status: String!
       }
 
       input ConfirmUploadInput {
@@ -324,11 +326,12 @@ export function createPresignedUrlPlugin(
                   });
 
                   return {
-                    uploadUrl: null,
-                    fileId: existingFile.id,
+                    uploadUrl: null as string | null,
+                    fileId: existingFile.id as string,
                     key: s3Key,
                     deduplicated: true,
-                    expiresAt: null,
+                    expiresAt: null as string | null,
+                    status: existingFile.status as string,
                   };
                 }
 
@@ -396,6 +399,7 @@ export function createPresignedUrlPlugin(
                   key: s3Key,
                   deduplicated: false,
                   expiresAt,
+                  status: 'pending',
                 };
               });
             });

graphile/graphile-presigned-url-plugin/src/types.ts

@@ -105,6 +105,8 @@ export interface RequestUploadUrlPayload {
   deduplicated: boolean;
   /** Presigned URL expiry time (null if deduplicated) */
   expiresAt: string | null;
+  /** File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files */
+  status: string;
 }
 
 /**

graphql/server-test/__tests__/__snapshots__/schema-snapshot.test.ts.snap

@@ -2106,6 +2106,11 @@ type RequestUploadUrlPayload {
 
   """Presigned URL expiry time (null if deduplicated)"""
   expiresAt: Datetime
+
+  """
+  File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files. Clients can use this to know immediately whether the file is usable.
+  """
+  status: String!
 }
 
 input ConfirmUploadInput {

graphql/server-test/__tests__/upload.integration.test.ts

@@ -49,6 +49,7 @@ const REQUEST_UPLOAD_URL = `
       key
       deduplicated
       expiresAt
+      status
     }
   }
 `;
@@ -158,6 +159,7 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.key).toBe(contentHash);
       expect(payload.deduplicated).toBe(false);
       expect(payload.expiresAt).toBeTruthy();
+      expect(payload.status).toBe('pending');
 
       uploadUrl = payload.uploadUrl;
       fileId = payload.fileId;
@@ -216,6 +218,7 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.key).toBe(contentHash);
       expect(payload.deduplicated).toBe(false);
       expect(payload.expiresAt).toBeTruthy();
+      expect(payload.status).toBe('pending');
 
       uploadUrl = payload.uploadUrl;
       fileId = payload.fileId;
@@ -271,6 +274,7 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.uploadUrl).toBeNull();
       expect(payload.expiresAt).toBeNull();
       expect(payload.fileId).toBeTruthy();
+      expect(payload.status).toBe('ready');
     });
   });
 });

graphql/test/__tests__/__snapshots__/graphile-test.test.ts.snap

@@ -3354,6 +3354,22 @@ that owns this entity instance (e.g., a data room ID, team ID).",
                 "ofType": null,
               },
             },
+            {
+              "args": [],
+              "deprecationReason": null,
+              "description": "File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files. Clients can use this to know immediately whether the file is usable.",
+              "isDeprecated": false,
+              "name": "status",
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "String",
+                  "ofType": null,
+                },
+              },
+            },
           ],
           "inputFields": null,
           "interfaces": [],

packages/upload-client/__tests__/upload.test.ts

@@ -59,6 +59,7 @@ describe('uploadFile', () => {
               key: HELLO_WORLD_HASH,
               deduplicated: false,
               expiresAt: new Date(Date.now() + 900_000).toISOString(),
+              status: 'pending',
             },
           };
         }
@@ -135,6 +136,7 @@ describe('uploadFile', () => {
               key: HELLO_WORLD_HASH,
               deduplicated: true,
               expiresAt: null,
+              status: 'ready',
             },
           };
         }
@@ -199,6 +201,7 @@ describe('uploadFile', () => {
               key: 'hash',
               deduplicated: false,
               expiresAt: new Date().toISOString(),
+              status: 'pending',
             },
           };
         }
@@ -230,6 +233,7 @@ describe('uploadFile', () => {
               key: 'hash',
               deduplicated: false,
               expiresAt: new Date().toISOString(),
+              status: 'pending',
             },
           };
         }
@@ -279,6 +283,7 @@ describe('uploadFile', () => {
               key: 'hash',
               deduplicated: false,
               expiresAt: new Date().toISOString(),
+              status: 'pending',
             },
           };
         }

packages/upload-client/src/queries.ts

@@ -13,6 +13,7 @@ export const REQUEST_UPLOAD_URL_MUTATION = `
       key
       deduplicated
       expiresAt
+      status
     }
   }
 `;

packages/upload-client/src/types.ts

@@ -32,6 +32,8 @@ export interface RequestUploadUrlPayload {
   deduplicated: boolean;
   /** Presigned URL expiry time (ISO string, null if deduplicated) */
   expiresAt: string | null;
+  /** File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files */
+  status: string;
 }
 
 export interface ConfirmUploadInput {

packages/upload-client/src/upload.ts

@@ -79,7 +79,7 @@ export async function uploadFile(options: UploadFileOptions): Promise<UploadResu
       fileId: requestPayload.fileId,
       key: requestPayload.key,
       deduplicated: true,
-      status: 'ready',
+      status: requestPayload.status,
     };
   }