refactor(codegen): remove dead maxFieldDepth code and enforce trailing commas

Author: pyramation

graphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap

@@ -107,13 +107,13 @@ exports[`client-generator generateOrmClientFile generates OrmClient class with e
 import type {
   GraphQLAdapter,
   GraphQLError,
-  QueryResult
+  QueryResult,
 } from '@constructive-io/graphql-types';
 
 export type {
   GraphQLAdapter,
   GraphQLError,
-  QueryResult
+  QueryResult,
 } from '@constructive-io/graphql-types';
 
 /**
@@ -125,33 +125,35 @@ export class FetchAdapter implements GraphQLAdapter {
 
   constructor(
     private endpoint: string,
-    headers?: Record<string, string>
+    headers?: Record<string, string>,
   ) {
     this.headers = headers ?? {};
   }
 
   async execute<T>(
     document: string,
-    variables?: Record<string, unknown>
+    variables?: Record<string, unknown>,
   ): Promise<QueryResult<T>> {
     const response = await fetch(this.endpoint, {
       method: 'POST',
       headers: {
         'Content-Type': 'application/json',
         Accept: 'application/json',
-        ...this.headers
+        ...this.headers,
       },
       body: JSON.stringify({
         query: document,
-        variables: variables ?? {}
-      })
+        variables: variables ?? {},
+      }),
     });
 
     if (!response.ok) {
       return {
         ok: false,
         data: null,
-        errors: [{ message: \`HTTP \${response.status}: \${response.statusText}\` }]
+        errors: [
+          { message: \`HTTP \${response.status}: \${response.statusText}\` },
+        ],
       };
     }
 
@@ -164,14 +166,14 @@ export class FetchAdapter implements GraphQLAdapter {
       return {
         ok: false,
         data: null,
-        errors: json.errors
+        errors: json.errors,
       };
     }
 
     return {
       ok: true,
       data: json.data as T,
-      errors: undefined
+      errors: undefined,
     };
   }
 
@@ -204,7 +206,7 @@ export interface OrmClientConfig {
 export class GraphQLRequestError extends Error {
   constructor(
     public readonly errors: GraphQLError[],
-    public readonly data: unknown = null
+    public readonly data: unknown = null,
   ) {
     const messages = errors.map((e) => e.message).join('; ');
     super(\`GraphQL Error: \${messages}\`);
@@ -222,14 +224,14 @@ export class OrmClient {
       this.adapter = new FetchAdapter(config.endpoint, config.headers);
     } else {
       throw new Error(
-        'OrmClientConfig requires either an endpoint or a custom adapter'
+        'OrmClientConfig requires either an endpoint or a custom adapter',
       );
     }
   }
 
   async execute<T>(
     document: string,
-    variables?: Record<string, unknown>
+    variables?: Record<string, unknown>,
   ): Promise<QueryResult<T>> {
     return this.adapter.execute<T>(document, variables);
   }
@@ -304,7 +306,7 @@ export interface UpdateArgs<TSelect, TWhere, TData> {
 export type FindOneArgs<
   TSelect,
   TIdName extends string = 'id',
-  TId = string
+  TId = string,
 > = {
   select?: TSelect;
 } & Record<TIdName, TId>;
@@ -337,9 +339,13 @@ export type DeepExact<T, Shape> = T extends Shape
     ? {
         [K in keyof T]: K extends keyof Shape
           ? T[K] extends { select: infer NS }
-            ? Extract<Shape[K], { select?: unknown }> extends { select?: infer ShapeNS }
+            ? Extract<Shape[K], { select?: unknown }> extends {
+                select?: infer ShapeNS;
+              }
               ? DeepExact<
-                  Omit<T[K], 'select'> & { select: DeepExact<NS, NonNullable<ShapeNS>> },
+                  Omit<T[K], 'select'> & {
+                    select: DeepExact<NS, NonNullable<ShapeNS>>;
+                  },
                   Extract<Shape[K], { select?: unknown }>
                 >
               : never

graphql/codegen/src/__tests__/codegen/client-generator.test.ts

@@ -7,34 +7,40 @@ import {
   generateCreateClientFile,
   generateOrmClientFile,
   generateQueryBuilderFile,
-  generateSelectTypesFile
+  generateSelectTypesFile,
 } from '../../core/codegen/orm/client-generator';
-import type { CleanFieldType, CleanRelations,CleanTable } from '../../types/schema';
+import type {
+  CleanFieldType,
+  CleanRelations,
+  CleanTable,
+} from '../../types/schema';
 
 // ============================================================================
 // Test Fixtures
 // ============================================================================
 
 const fieldTypes = {
   uuid: { gqlType: 'UUID', isArray: false } as CleanFieldType,
-  string: { gqlType: 'String', isArray: false } as CleanFieldType
+  string: { gqlType: 'String', isArray: false } as CleanFieldType,
 };
 
 const emptyRelations: CleanRelations = {
   belongsTo: [],
   hasOne: [],
   hasMany: [],
-  manyToMany: []
+  manyToMany: [],
 };
 
-function createTable(partial: Partial<CleanTable> & { name: string }): CleanTable {
+function createTable(
+  partial: Partial<CleanTable> & { name: string },
+): CleanTable {
   return {
     name: partial.name,
     fields: partial.fields ?? [],
     relations: partial.relations ?? emptyRelations,
     query: partial.query,
     inflection: partial.inflection,
-    constraints: partial.constraints
+    constraints: partial.constraints,
   };
 }
 
@@ -91,13 +97,25 @@ describe('client-generator', () => {
         createTable({
           name: 'User',
           fields: [{ name: 'id', type: fieldTypes.uuid }],
-          query: { all: 'users', one: 'user', create: 'createUser', update: 'updateUser', delete: 'deleteUser' }
+          query: {
+            all: 'users',
+            one: 'user',
+            create: 'createUser',
+            update: 'updateUser',
+            delete: 'deleteUser',
+          },
         }),
         createTable({
           name: 'Post',
           fields: [{ name: 'id', type: fieldTypes.uuid }],
-          query: { all: 'posts', one: 'post', create: 'createPost', update: 'updatePost', delete: 'deletePost' }
-        })
+          query: {
+            all: 'posts',
+            one: 'post',
+            create: 'createPost',
+            update: 'updatePost',
+            delete: 'deletePost',
+          },
+        }),
       ];
 
       const result = generateCreateClientFile(tables, false, false);
@@ -114,8 +132,14 @@ describe('client-generator', () => {
         createTable({
           name: 'User',
           fields: [{ name: 'id', type: fieldTypes.uuid }],
-          query: { all: 'users', one: 'user', create: 'createUser', update: 'updateUser', delete: 'deleteUser' }
-        })
+          query: {
+            all: 'users',
+            one: 'user',
+            create: 'createUser',
+            update: 'updateUser',
+            delete: 'deleteUser',
+          },
+        }),
       ];
 
       const result = generateCreateClientFile(tables, true, true);
@@ -124,7 +148,9 @@ describe('client-generator', () => {
       expect(result.content).toContain('createQueryOperations');
       expect(result.content).toContain('createMutationOperations');
       expect(result.content).toContain('query: createQueryOperations(client)');
-      expect(result.content).toContain('mutation: createMutationOperations(client)');
+      expect(result.content).toContain(
+        'mutation: createMutationOperations(client)',
+      );
     });
   });
 });