Commit 65b829b
fix(graphql-query): address PR review (drop .js, use @constructive-io/fetch, drop exports)
Three review comments from pyramation:
1. graphql/query/src/runtime/index.ts — drop `.js` extensions from
relative re-exports; the monorepo is CJS, not ESM.
2. graphql/query/src/runtime/localhost-fetch.ts — replace with
@constructive-io/fetch (the shipped, single-purpose package from
constructive-io/dev-utils). Identical createFetch / FetchFunction
surface; same fix for *.localhost DNS + Host header. File deleted
in favor of the dependency.
3. graphql/query/package.json — drop the `exports` map; monorepo
convention is main/module/types only. Sub-path
`@constructive-io/graphql-query/runtime` still resolves via
filesystem walk under classic moduleResolution: node.
Verified: graphql/query builds and tests pass (18 tests, 29 snapshots);
constructive-sdk builds clean and `require.resolve` resolves the
sub-path correctly without `exports`. Pre-existing ESLint v9 config
issue unchanged.
Lockfile intentionally not updated to keep this PR's diff focused —
CI uses non-frozen `pnpm install` and will pick up
@constructive-io/fetch on install.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 815edac commit 65b829b
3 files changed
Lines changed: 6 additions & 171 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 9 | | |
22 | 10 | | |
23 | 11 | | |
| |||
42 | 30 | | |
43 | 31 | | |
44 | 32 | | |
| 33 | + | |
45 | 34 | | |
46 | 35 | | |
47 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | | - | |
24 | 22 | | |
25 | 23 | | |
26 | | - | |
27 | | - | |
28 | | - | |
| 24 | + | |
| 25 | + | |
This file was deleted.
0 commit comments