fix(lint): resolve remaining non-autofixable lint errors

pyramation · pyramation · commit 853436620e96 · 2026-07-31T22:31:27.000Z
Semantics-preserving: Object.prototype.hasOwnProperty.call() instead of direct
hasOwnProperty access, redundant regex escapes dropped, comments in empty
blocks, a dead `info.version;` expression removed, and two targeted
eslint-disable comments (this-alias in a test fixture, async promise executor
in s3-utils download).
diff --git a/graphile/graphile-llm/src/__tests__/graphile-llm.test.ts b/graphile/graphile-llm/src/__tests__/graphile-llm.test.ts
@@ -1067,7 +1067,11 @@ describe('Real Ollama + unifiedSearch + pgvector RRF integration', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
diff --git a/graphile/graphile-presigned-url-plugin/src/plugin.ts b/graphile/graphile-presigned-url-plugin/src/plugin.ts
@@ -35,7 +35,7 @@ const MAX_CONTENT_HASH_LENGTH = 128;
 const MAX_CONTENT_TYPE_LENGTH = 255;
 const MAX_CUSTOM_KEY_LENGTH = 1024;
 const SHA256_HEX_REGEX = /^[a-f0-9]{64}$/;
-const CUSTOM_KEY_REGEX = /^[a-zA-Z0-9][a-zA-Z0-9_.\-\/]*$/;
+const CUSTOM_KEY_REGEX = /^[a-zA-Z0-9][a-zA-Z0-9_.\-/]*$/;
 
 // --- Helpers ---
 
diff --git a/graphile/graphile-search/src/__tests__/rrf-scoring.test.ts b/graphile/graphile-search/src/__tests__/rrf-scoring.test.ts
@@ -169,7 +169,11 @@ describe('RRF scoring — single adapter scenarios', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -362,7 +366,11 @@ describe('RRF scoring — multi-adapter combinations', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -605,7 +613,11 @@ describe('RRF scoring — unifiedSearch + pgvector fusion (simulating LLM path)'
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -793,7 +805,11 @@ describe('RRF scoring — chunk-aware tables', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -965,7 +981,11 @@ describe('RRF scoring — custom @searchConfig weights', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -1090,7 +1110,11 @@ describe('RRF scoring — recency boost', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
@@ -1209,7 +1233,11 @@ describe('RRF scoring — custom rrfK parameter', () => {
 
   afterAll(async () => {
     if (db) {
-      try { await db.client.query('ROLLBACK'); } catch {}
+      try {
+        await db.client.query('ROLLBACK');
+      } catch {
+        // ignore
+      }
     }
     if (teardown) await teardown();
   });
diff --git a/pgpm/ast/__tests__/plan-rename.test.ts b/pgpm/ast/__tests__/plan-rename.test.ts
@@ -78,7 +78,7 @@ describe('renameInPlanContent', () => {
     expect(out).toContain(`schemas/mod_${n - 1}/tables/t_${n - 1}`);
     expect(out).toContain('[schemas/mod_0/tables/t_0]');
     // No hyphenated change tokens should remain (metadata/comments still have them).
-    expect(out).not.toMatch(/(^|[\s\[])schemas\/mod-\d/m);
+    expect(out).not.toMatch(/(^|[\s[])schemas\/mod-\d/m);
     expect(elapsedMs).toBeLessThan(2000);
   });
 });
diff --git a/pgpm/ast/src/files/extension/reader.ts b/pgpm/ast/src/files/extension/reader.ts
@@ -36,13 +36,13 @@ export function parseControlContent(contents: string): { requires: string[]; ver
     .find((line) => /^requires/.test(line))
     ?.split('=')[1]
     .split(',')
-    .map((req) => req.replace(/[\'\s]*/g, '').trim()) || [];
+    .map((req) => req.replace(/['\s]*/g, '').trim()) || [];
 
   const version = contents
     .split('\n')
     .find((line) => /^default_version/.test(line))
     ?.split('=')[1]
-    .replace(/[\']*/g, '')
+    .replace(/[']*/g, '')
     .trim() || '';
 
   return { requires, version };
diff --git a/pgpm/ast/src/files/sql/header.ts b/pgpm/ast/src/files/sql/header.ts
@@ -241,7 +241,7 @@ export function scanDeployScript(
     }
 
     if (/:/.test(line)) {
-      const m2 = line.match(/^-- Deploy ([^:]*):([\w\/]+)(?:\s+to\s+pg)?/);
+      const m2 = line.match(/^-- Deploy ([^:]*):([\w/]+)(?:\s+to\s+pg)?/);
       if (m2) {
         const actualProject = m2[1];
         const keyToTest = m2[2];
diff --git a/pgpm/ast/src/plan-rename.ts b/pgpm/ast/src/plan-rename.ts
@@ -18,7 +18,7 @@ export function renameInPlanContent(content: string, renames: Map<string, string
   if (renames.size === 0) return content;
 
   // One regex, compiled once per call (not per line or per rename).
-  const tokenRe = /(^|[\s\[])([^\s\[\]@]+)(?=$|[\s\]@])/g;
+  const tokenRe = /(^|[\s[])([^\s[\]@]+)(?=$|[\s\]@])/g;
 
   return content
     .split('\n')
diff --git a/pgpm/cli/src/commands/package.ts b/pgpm/cli/src/commands/package.ts
@@ -134,7 +134,6 @@ export default async (
   project.ensureModule();
 
   const info = project.getModuleInfo();
-  info.version;
 
   await writePackage({
     version: info.version,
diff --git a/pgpm/core/src/core/class/pgpm.ts b/pgpm/core/src/core/class/pgpm.ts
@@ -765,7 +765,9 @@ export class PgpmPackage {
                   }
                 }
               }
-            } catch {}
+            } catch {
+              // ignore
+            }
           }
 
           if (!hasTagDependency && !deps[firstKey].includes(depToken)) {
diff --git a/pgpm/core/src/migrate/clean.ts b/pgpm/core/src/migrate/clean.ts
@@ -4,7 +4,7 @@ import { deparse,parse } from 'pgsql-parser';
 const filterStatements = (stmts: RawStmt[]): { filteredStmts: RawStmt[], hasFiltered: boolean } => {
   const filteredStmts = stmts.filter(node => {
     const stmt = node.stmt;
-    return stmt && !stmt.hasOwnProperty('TransactionStmt');
+    return stmt && !Object.prototype.hasOwnProperty.call(stmt, 'TransactionStmt');
   });
   
   const hasFiltered = filteredStmts.length !== stmts.length;
diff --git a/pgpm/core/src/migrate/client.ts b/pgpm/core/src/migrate/client.ts
@@ -447,6 +447,7 @@ export class PgpmMigrate {
         }
       }
     } finally {
+      // no cleanup
     }
     
     if (failed.length > 0) {
diff --git a/pgpm/core/src/packaging/package.ts b/pgpm/core/src/packaging/package.ts
@@ -45,8 +45,10 @@ const filterStatements = (stmts: RawStmt[], stripTransactions: boolean): RawStmt
   if (!stripTransactions) return stmts;
   return stmts.filter(node => {
     const stmt = node.stmt;
-    return !stmt.hasOwnProperty('TransactionStmt') && 
-           !stmt.hasOwnProperty('CreateExtensionStmt');
+    return (
+      !Object.prototype.hasOwnProperty.call(stmt, 'TransactionStmt') &&
+      !Object.prototype.hasOwnProperty.call(stmt, 'CreateExtensionStmt')
+    );
   });
 };
 
@@ -163,7 +165,7 @@ export const writePackage = async ({
     writeFileSync(
       controlPath,
       control.replace(
-        /default_version = '[0-9\.]+'/,
+        /default_version = '[0-9.]+'/,
         `default_version = '${version}'`
       )
     );
diff --git a/pgpm/core/src/packaging/transform.ts b/pgpm/core/src/packaging/transform.ts
@@ -39,14 +39,14 @@ export const transformProps = (obj: any, props: TransformProps): any => {
     copy = {};
     for (const attr in obj) {
       if (Object.prototype.hasOwnProperty.call(obj, attr)) {
-        if (props.hasOwnProperty(attr)) {
+        if (Object.prototype.hasOwnProperty.call(props, attr)) {
           const propRule = props[attr];
           if (typeof propRule === 'function') {
             // Apply function transformation
             copy[attr] = propRule(obj[attr]);
           } else if (typeof propRule === 'object' && propRule !== null) {
             // Apply value-based transformation
-            if (propRule.hasOwnProperty(obj[attr])) {
+            if (Object.prototype.hasOwnProperty.call(propRule, obj[attr])) {
               copy[attr] = propRule[obj[attr]];
             } else {
               copy[attr] = transformProps(obj[attr], props);
diff --git a/pgpm/core/src/workspace/utils.ts b/pgpm/core/src/workspace/utils.ts
@@ -31,6 +31,6 @@ export const sluggify = (text: string): string => {
   return text.toString().toLowerCase().trim()
     .replace(/\s+/g, '-')           // Replace spaces with -
     .replace(/&/g, '-and-')         // Replace & with 'and'
-    .replace(/[^\w\-]+/g, '')       // Remove all non-word chars
-    .replace(/\-\-+/g, '-');        // Replace multiple - with single -
+    .replace(/[^\w-]+/g, '')       // Remove all non-word chars
+    .replace(/--+/g, '-');        // Replace multiple - with single -
 };
diff --git a/pgpm/core/test-utils/MigrateTestFixture.ts b/pgpm/core/test-utils/MigrateTestFixture.ts
@@ -61,6 +61,7 @@ export class MigrateTestFixture {
     const pool = getPgPool(pgConfig);
     this.pools.push(pool);
 
+    // eslint-disable-next-line @typescript-eslint/no-this-alias
     const fixture = this;
     const db: TestDatabase = {
       name: dbName,
diff --git a/pgpm/env/src/config.ts b/pgpm/env/src/config.ts
@@ -57,6 +57,7 @@ export const loadConfigSync = (cwd: string = process.cwd()): PgpmOptions => {
       const configDir = walkUp(cwd, filename);
       return loadConfigSyncFromDir(configDir);
     } catch {
+      // ignore
     }
   }
   
@@ -74,6 +75,7 @@ export const resolvePgpmPath = (cwd: string = process.cwd()): string | undefined
     try {
       return walkUp(cwd, filename);
     } catch {
+      // ignore
     }
   }
   
diff --git a/postgres/introspectron/src/gql.ts b/postgres/introspectron/src/gql.ts
@@ -102,13 +102,13 @@ export const parseGraphQuery = (introQuery: IntrospectionQueryResult) => {
       return getInputForQueries(input.ofType!, context);
     }
 
-    if (input.kind === 'INPUT_OBJECT' && input.name && HASH.hasOwnProperty(input.name)) {
+    if (input.kind === 'INPUT_OBJECT' && input.name && Object.prototype.hasOwnProperty.call(HASH, input.name)) {
       const schema = HASH[input.name];
       context.properties = schema.inputFields!.map((field) => ({ name: field.name, type: field.type })).reduce((m3, v) => {
         m3[v.name] = v;
         return m3;
       }, {} as Record<string, any>);
-    } else if (input.kind === 'OBJECT' && input.name && HASH.hasOwnProperty(input.name)) {
+    } else if (input.kind === 'OBJECT' && input.name && Object.prototype.hasOwnProperty.call(HASH, input.name)) {
       const schema = HASH[input.name];
       context.properties = schema.fields!.map((field) => ({ name: field.name, type: field.type })).reduce((m3, v) => {
         m3[v.name] = v;
@@ -141,13 +141,13 @@ export const parseGraphQuery = (introQuery: IntrospectionQueryResult) => {
       return getInputForMutations(input.ofType!, context);
     }
 
-    if (input.kind === 'INPUT_OBJECT' && input.name && HASH.hasOwnProperty(input.name)) {
+    if (input.kind === 'INPUT_OBJECT' && input.name && Object.prototype.hasOwnProperty.call(HASH, input.name)) {
       const schema = HASH[input.name];
       context.properties = schema.inputFields!.map((field) => getInputForMutations(field.type, { name: field.name })).reduce((m3, v) => {
         m3[v.name!] = v;
         return m3;
       }, {} as Record<string, any>);
-    } else if (input.kind === 'OBJECT' && input.name && HASH.hasOwnProperty(input.name)) {
+    } else if (input.kind === 'OBJECT' && input.name && Object.prototype.hasOwnProperty.call(HASH, input.name)) {
       const schema = HASH[input.name];
       context.properties = schema.fields!.map((field) => ({ name: field.name, type: field.type })).reduce((m3, v) => {
         m3[v.name] = v;
@@ -169,7 +169,7 @@ export const parseGraphQuery = (introQuery: IntrospectionQueryResult) => {
     const props = mutation.args.reduce((m2, arg) => {
       const type = arg.type?.ofType?.name;
       const isNotNull = arg.type?.kind === 'NON_NULL';
-      if (type && HASH.hasOwnProperty(type)) {
+      if (type && Object.prototype.hasOwnProperty.call(HASH, type)) {
         const schema = HASH[type];
         const fields = schema.inputFields!.filter((a) => a.name !== 'clientMutationId');
         const properties = fields.map((a) => getInputForMutations(a.type, { name: a.name })).reduce((m3, v) => {
diff --git a/postgres/pgsql-client/src/client.ts b/postgres/pgsql-client/src/client.ts
@@ -35,7 +35,9 @@ export class PgClient {
     if (this.connectPromise) {
       try {
         await this.connectPromise;
-      } catch {}
+      } catch {
+        // ignore
+      }
     }
   }
 
diff --git a/uploads/s3-utils/src/utils.ts b/uploads/s3-utils/src/utils.ts
@@ -36,6 +36,7 @@ export const download = async ({
   bucket,
   key,
 }: FileOperationArgs & { writeStream: NodeJS.WritableStream }): Promise<void> => {
+  // eslint-disable-next-line no-async-promise-executor
   return new Promise(async (resolve, reject) => {
     try {
       const errors: Error[] = [];

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ export function scanDeployScript(`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`if (/:/.test(line)) {`
`244`		`- const m2 = line.match(/^-- Deploy ([^:]*):([\w\/]+)(?:\s+to\s+pg)?/);`
	`244`	`+ const m2 = line.match(/^-- Deploy ([^:]*):([\w/]+)(?:\s+to\s+pg)?/);`
`245`	`245`	`if (m2) {`
`246`	`246`	`const actualProject = m2[1];`
`247`	`247`	`const keyToTest = m2[2];`
Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,9 @@ export class PgpmPackage {`
`765`	`765`	`}`
`766`	`766`	`}`
`767`	`767`	`}`
`768`		`- } catch {}`
	`768`	`+ } catch {`
	`769`	`+ // ignore`
	`770`	`+ }`
`769`	`771`	`}`
`770`	`772`
`771`	`773`	`if (!hasTagDependency && !deps[firstKey].includes(depToken)) {`