Merge pull request #1124 from constructive-io/feat/rename-email-sms-functions

refactor: rename email/SMS cloud functions to purpose-driven names

Author: pyramation

CLAUDE.md

@@ -71,7 +71,7 @@ React Query Hooks or Prisma-like ORM Client
 | `packages/` | Shared utilities - CLI (`cnc`), ORM base, query builder, server utils, client |
 | `uploads/` | File streaming - S3/MinIO, ETags, content-type detection, UUID hashing |
 | `jobs/` | Knative job scheduling - worker, scheduler, service, functions |
-| `functions/` | Knative cloud functions (e.g., send-email-link) |
+| `functions/` | Knative cloud functions (e.g., send-verification-link, send-email) |
 
 ### Key Packages & CLIs
 

docker-compose.jobs.yml

@@ -72,11 +72,11 @@ services:
         aliases:
           - constructive-server
 
-  # Send email link function (invite, password reset, verification)
-  send-email-link:
-    container_name: send-email-link
+  # Send verification link function (invite, password reset, verification)
+  send-verification-link:
+    container_name: send-verification-link
     image: constructive:dev
-    entrypoint: ["node", "functions/send-email-link/dist/index.js"]
+    entrypoint: ["node", "functions/send-verification-link/dist/index.js"]
     environment:
       NODE_ENV: development
       LOG_LEVEL: info
@@ -98,7 +98,7 @@ services:
       # localhost-style hosts in DRY RUN mode:
       # http://localhost:LOCAL_APP_PORT/...
       LOCAL_APP_PORT: "3000"
-      SEND_EMAIL_LINK_DRY_RUN: "${SEND_EMAIL_LINK_DRY_RUN:-true}"
+      SEND_VERIFICATION_LINK_DRY_RUN: "${SEND_VERIFICATION_LINK_DRY_RUN:-true}"
     ports:
       - "8082:8080"
     networks:
@@ -110,7 +110,7 @@ services:
     image: constructive:dev
     entrypoint: ["node", "jobs/knative-job-service/dist/run.js"]
     depends_on:
-      - send-email-link
+      - send-verification-link
     environment:
       NODE_ENV: development
 
@@ -124,7 +124,7 @@ services:
 
       # Worker configuration
       JOBS_SUPPORT_ANY: "false"
-      JOBS_SUPPORTED: "send-email-link"
+      JOBS_SUPPORTED: "email:send_verification_link,email:send_email"
       HOSTNAME: "knative-job-service-1"
 
       # Callback HTTP server (job completion callbacks)
@@ -134,10 +134,10 @@ services:
       JOBS_CALLBACK_HOST: "knative-job-service"
 
       # Function gateway base URL (used by worker when no dev map is present)
-      INTERNAL_GATEWAY_URL: "http://send-email-link:8080"
+      INTERNAL_GATEWAY_URL: "http://send-verification-link:8080"
 
       # Development-only map from task identifier -> function URL
-      INTERNAL_GATEWAY_DEVELOPMENT_MAP: '{"send-email-link":"http://send-email-link:8080"}'
+      INTERNAL_GATEWAY_DEVELOPMENT_MAP: '{"email:send_verification_link":"http://send-verification-link:8080","email:send_email":"http://send-email:8080"}'
 
     ports:
       - "8080:8080"

docker-compose.local-email.yml

@@ -6,7 +6,7 @@
 # Services:
 #   - mailpit (SMTP: 1025, Web UI: 8025)
 #   - constructive-admin-server (3002)
-#   - send-email-link (8082)
+#   - send-verification-link (8082)
 #   - knative-job-service (8080)
 #
 # Prerequisites:
@@ -57,11 +57,11 @@ services:
     networks:
       - constructive-net
 
-  # Send email link function (uses SMTP to Mailpit)
-  send-email-link:
-    container_name: send-email-link
+  # Send verification link function (uses SMTP to Mailpit)
+  send-verification-link:
+    container_name: send-verification-link
     image: constructive:dev
-    entrypoint: ["node", "functions/send-email-link/dist/index.js"]
+    entrypoint: ["node", "functions/send-verification-link/dist/index.js"]
     depends_on:
       - mailpit
       - constructive-admin-server
@@ -81,19 +81,19 @@ services:
       # Local app port for email links
       LOCAL_APP_PORT: "3011"
       ALLOW_LOCALHOST: "true"
-      SEND_EMAIL_LINK_DRY_RUN: "false"
+      SEND_VERIFICATION_LINK_DRY_RUN: "false"
     ports:
       - "8082:8080"
     networks:
       - constructive-net
 
-  # Job service (polls app_jobs, triggers send-email-link)
+  # Job service (polls app_jobs, triggers send-verification-link)
   knative-job-service:
     container_name: knative-job-service
     image: constructive:dev
     entrypoint: ["node", "jobs/knative-job-service/dist/run.js"]
     depends_on:
-      - send-email-link
+      - send-verification-link
     extra_hosts:
       - "host.docker.internal:host-gateway"
     environment:
@@ -107,15 +107,15 @@ services:
       JOBS_SCHEMA: app_jobs
       # Worker config
       JOBS_SUPPORT_ANY: "true"
-      JOBS_SUPPORTED: "send-email-link"
+      JOBS_SUPPORTED: "email:send_verification_link,email:send_email"
       HOSTNAME: "local-worker"
       # Callback server
       INTERNAL_JOBS_CALLBACK_PORT: "8080"
       INTERNAL_JOBS_CALLBACK_URL: "http://knative-job-service:8080/callback"
       JOBS_CALLBACK_HOST: "knative-job-service"
       # Function gateway
-      INTERNAL_GATEWAY_URL: "http://send-email-link:8080"
-      INTERNAL_GATEWAY_DEVELOPMENT_MAP: '{"send-email-link":"http://send-email-link:8080"}'
+      INTERNAL_GATEWAY_URL: "http://send-verification-link:8080"
+      INTERNAL_GATEWAY_DEVELOPMENT_MAP: '{"email:send_verification_link":"http://send-verification-link:8080","email:send_email":"http://send-email:8080"}'
     ports:
       - "8080:8080"
     networks:

docker/functions/simple-email.Dockerfile docker/functions/send-email.Dockerfiledocker/functions/simple-email.Dockerfile renamed to docker/functions/send-email.Dockerfile

@@ -21,8 +21,8 @@ COPY . .
 RUN set -eux; \
     pnpm install --frozen-lockfile
 
-# Build the simple-email function and its dependencies
-ARG FUNCTION_DIR=functions/simple-email
+# Build the send-email function and its dependencies
+ARG FUNCTION_DIR=functions/send-email
 RUN set -eux; \
     pnpm --filter "./${FUNCTION_DIR}"... build
 
@@ -40,11 +40,11 @@ RUN set -eux; \
 # Copy the built repo from builder (keeps pnpm workspace wiring intact)
 COPY --from=build /app /app
 
-# simple-email function workspace directory
-WORKDIR /app/functions/simple-email
+# send-email function workspace directory
+WORKDIR /app/functions/send-email
 
 ENV NODE_ENV=production
 
-# Entry point for the simple-email function
+# Entry point for the send-email function
 CMD ["node", "dist/index.js"]
 

functions/simple-email/CHANGELOG.md functions/send-email/CHANGELOG.mdfunctions/simple-email/CHANGELOG.md renamed to functions/send-email/CHANGELOG.md

@@ -1,4 +1,4 @@
-# @constructive-io/simple-email-fn
+# @constructive-io/send-email-fn
 
 <p align="center" width="100%">
   <img height="250" src="https://raw.githubusercontent.com/constructive-io/constructive/refs/heads/main/assets/outline-logo.svg" />
@@ -9,7 +9,7 @@
     <img height="20" src="https://github.com/constructive-io/constructive/actions/workflows/run-tests.yaml/badge.svg" />
   </a>
    <a href="https://github.com/constructive-io/constructive/blob/main/LICENSE"><img height="20" src="https://img.shields.io/badge/license-MIT-blue.svg"/></a>
-   <a href="https://www.npmjs.com/package/@constructive-io/simple-email-fn"><img height="20" src="https://img.shields.io/github/package-json/v/constructive-io/constructive?filename=functions%2Fsimple-email%2Fpackage.json"/></a>
+   <a href="https://www.npmjs.com/package/@constructive-io/send-email-fn"><img height="20" src="https://img.shields.io/github/package-json/v/constructive-io/constructive?filename=functions%2Fsend-email%2Fpackage.json"/></a>
 </p>
 
 Simple Knative-compatible email function used with the Constructive jobs system.
@@ -21,7 +21,7 @@ without needing a real mail provider configured.
 
 ## Expected job payload
 
-Jobs should use `task_identifier = 'simple-email'` (or whatever route you
+Jobs should use `task_identifier = 'email:send_email'` (or whatever route you
 configure at your Knative gateway) and a JSON payload like:
 
 ```json
@@ -78,7 +78,7 @@ Email provider configuration is only required when not running in dry‑run mode
 
 Optional:
 
-- `SIMPLE_EMAIL_DRY_RUN` (`true`/`false`): log only, skip send.
+- `SEND_EMAIL_DRY_RUN` (`true`/`false`): log only, skip send.
 - `EMAIL_SEND_USE_SMTP` (`true`/`false`): use SMTP (`simple-smtp-server`).
 
 Mailgun (`@launchql/postmaster`) env vars when `EMAIL_SEND_USE_SMTP` is false:
@@ -100,7 +100,7 @@ SMTP env vars when `EMAIL_SEND_USE_SMTP` is true:
 From the repo root:
 
 ```bash
-pnpm --filter="@constructive-io/simple-email-fn" build
+pnpm --filter="@constructive-io/send-email-fn" build
 ```
 
 This compiles TypeScript into `dist/`.

functions/simple-email/README.md functions/send-email/README.mdfunctions/simple-email/README.md renamed to functions/send-email/README.md

@@ -1,5 +1,5 @@
 {
-  "name": "@constructive-io/simple-email-fn",
+  "name": "@constructive-io/send-email-fn",
   "version": "1.11.0",
   "description": "Simple Knative email function that sends emails directly from job payload",
   "author": "Constructive <developers@constructive.io>",

functions/simple-email/package.json functions/send-email/package.jsonfunctions/simple-email/package.json renamed to functions/send-email/package.json

@@ -27,9 +27,9 @@ const getRequiredField = (
   return value;
 };
 
-const isDryRun = parseEnvBoolean(process.env.SIMPLE_EMAIL_DRY_RUN) ?? false;
+const isDryRun = parseEnvBoolean(process.env.SEND_EMAIL_DRY_RUN ?? process.env.SIMPLE_EMAIL_DRY_RUN) ?? false;
 const useSmtp = parseEnvBoolean(process.env.EMAIL_SEND_USE_SMTP) ?? false;
-const logger = createLogger('simple-email');
+const logger = createLogger('send-email');
 const app = createJobApp();
 
 app.post('/', async (req: any, res: any, next: any) => {