fix: update snapshots, tests, and seeds for storage simplification

- Remove confirmUpload and status from graphile-test.test.ts.snap
- Remove ConfirmUploadInput/Payload types from schema-snapshot.test.ts.snap
- Rewrite upload.integration.test.ts: remove confirmUpload tests, remove status assertions
- Update seed SQL: remove upload_requests table, remove status from files, add UNIQUE(bucket_id, key)
- Remove upload_requests_table_id/name from storage_module seed
- Update README and package.json descriptions

Author: pyramation

graphile/graphile-presigned-url-plugin/README.md

@@ -17,11 +17,9 @@ Presigned URL upload plugin for PostGraphile v5.
 ## Features
 
 - `requestUploadUrl` mutation — generates presigned PUT URLs for direct client-to-S3 upload
-- `confirmUpload` mutation — verifies upload and transitions file status to 'ready'
 - `downloadUrl` computed field — presigned GET URLs for private files, public URLs for public files
 - Content-hash based S3 keys (SHA-256) with automatic deduplication
 - Per-bucket MIME type and file size validation
-- Upload request tracking for audit and rate limiting
 
 ## Usage
 

graphile/graphile-presigned-url-plugin/package.json

@@ -1,7 +1,7 @@
 {
   "name": "graphile-presigned-url-plugin",
   "version": "0.7.0",
-  "description": "Presigned URL upload plugin for PostGraphile v5 — requestUploadUrl, confirmUpload mutations and downloadUrl computed field",
+  "description": "Presigned URL upload plugin for PostGraphile v5 — requestUploadUrl mutation and downloadUrl computed field",
   "author": "Constructive <developers@constructive.io>",
   "homepage": "https://github.com/constructive-io/constructive",
   "license": "MIT",

graphql/server-test/__fixtures__/seed/simple-seed-storage/schema.sql

@@ -1,5 +1,5 @@
 -- Schema creation for simple-seed-storage test scenario
--- Creates the app schema with storage tables (buckets, files, upload_requests)
+-- Creates the app schema with storage tables (buckets, files)
 
 -- Create app schemas
 CREATE SCHEMA IF NOT EXISTS "simple-storage-public";
@@ -45,32 +45,13 @@ CREATE TABLE IF NOT EXISTS "simple-storage-public".files (
   filename text,
   owner_id uuid,
   is_public boolean NOT NULL DEFAULT false,
-  status text NOT NULL DEFAULT 'pending',
   created_at timestamptz DEFAULT now(),
-  updated_at timestamptz DEFAULT now()
+  updated_at timestamptz DEFAULT now(),
+  UNIQUE (bucket_id, key)
 );
 
 COMMENT ON TABLE "simple-storage-public".files IS E'@storageFiles\nStorage files table';
 
--- Upload requests table
-CREATE TABLE IF NOT EXISTS "simple-storage-public".upload_requests (
-  id uuid PRIMARY KEY DEFAULT uuid_generate_v4(),
-  file_id uuid NOT NULL REFERENCES "simple-storage-public".files(id),
-  actor_id uuid,
-  bucket_id uuid NOT NULL REFERENCES "simple-storage-public".buckets(id),
-  key text NOT NULL,
-  content_type text NOT NULL,
-  content_hash text,
-  status text NOT NULL DEFAULT 'issued',
-  expires_at timestamptz,
-  confirmed_at timestamptz,
-  ip_address inet,
-  user_agent text,
-  created_at timestamptz DEFAULT now(),
-  updated_at timestamptz DEFAULT now()
-);
-
 -- Grant table permissions (allow anonymous to do CRUD for tests — no RLS)
 GRANT SELECT, INSERT, UPDATE, DELETE ON "simple-storage-public".buckets TO administrator, authenticated, anonymous;
 GRANT SELECT, INSERT, UPDATE, DELETE ON "simple-storage-public".files TO administrator, authenticated, anonymous;
-GRANT SELECT, INSERT, UPDATE, DELETE ON "simple-storage-public".upload_requests TO administrator, authenticated, anonymous;

graphql/server-test/__fixtures__/seed/simple-seed-storage/setup.sql

@@ -47,10 +47,8 @@ CREATE TABLE IF NOT EXISTS metaschema_modules_public.storage_module (
   private_schema_id uuid NOT NULL DEFAULT uuid_nil(),
   buckets_table_id uuid NOT NULL DEFAULT uuid_nil(),
   files_table_id uuid NOT NULL DEFAULT uuid_nil(),
-  upload_requests_table_id uuid NOT NULL DEFAULT uuid_nil(),
   buckets_table_name text NOT NULL DEFAULT 'app_buckets',
   files_table_name text NOT NULL DEFAULT 'app_files',
-  upload_requests_table_name text NOT NULL DEFAULT 'app_upload_requests',
   membership_type int DEFAULT NULL,
   entity_table_id uuid NULL,
   endpoint text NULL,

graphql/server-test/__fixtures__/seed/simple-seed-storage/test-data.sql

@@ -43,16 +43,6 @@ VALUES (
   NULL
 ) ON CONFLICT (id) DO NOTHING;
 
--- upload_requests
-INSERT INTO metaschema_public.table (id, database_id, schema_id, name, description)
-VALUES (
-  'b0000001-0000-0000-0000-000000000003',
-  '80a2eaaf-f77e-4bfe-8506-df929ef1b8d9',
-  '6dbae92a-5450-401b-1ed5-d69e7754940d',
-  'upload_requests',
-  NULL
-) ON CONFLICT (id) DO NOTHING;
-
 -- =====================================================
 -- SERVICES DATA
 -- =====================================================
@@ -77,7 +67,6 @@ INSERT INTO metaschema_modules_public.storage_module (
   schema_id,
   buckets_table_id,
   files_table_id,
-  upload_requests_table_id,
   endpoint,
   public_url_prefix,
   provider,
@@ -89,7 +78,6 @@ VALUES (
   '6dbae92a-5450-401b-1ed5-d69e7754940d',
   'b0000001-0000-0000-0000-000000000001',
   'b0000001-0000-0000-0000-000000000002',
-  'b0000001-0000-0000-0000-000000000003',
   NULL,  -- use global CDN_ENDPOINT
   NULL,  -- use global CDN_PUBLIC_URL_PREFIX
   'minio',

graphql/server-test/__tests__/__snapshots__/schema-snapshot.test.ts.snap

@@ -2106,27 +2106,6 @@ type RequestUploadUrlPayload {
 
   """Presigned URL expiry time (null if deduplicated)"""
   expiresAt: Datetime
-
-  """
-  File status — 'pending' for fresh uploads, 'ready' or 'processed' for deduplicated files. Clients can use this to know immediately whether the file is usable.
-  """
-  status: String!
-}
-
-input ConfirmUploadInput {
-  """The file ID returned by requestUploadUrl"""
-  fileId: UUID!
-}
-
-type ConfirmUploadPayload {
-  """The confirmed file ID"""
-  fileId: UUID!
-
-  """New file status"""
-  status: String!
-
-  """Whether confirmation succeeded"""
-  success: Boolean!
 }
 
 """The root query type which gives access points into the data universe."""
@@ -2419,18 +2398,6 @@ type Mutation {
     input: RequestUploadUrlInput!
   ): RequestUploadUrlPayload
 
-  """
-  Confirm that a file has been uploaded to S3.
-  Verifies the object exists in S3, checks content-type,
-  and transitions the file status from 'pending' to 'ready'.
-  """
-  confirmUpload(
-    """
-    The exclusive input argument for this mutation. An object type, make sure to see documentation for this object’s fields.
-    """
-    input: ConfirmUploadInput!
-  ): ConfirmUploadPayload
-
   """
   Provision an S3 bucket for a logical bucket in the database.
   Reads the bucket config via RLS, then creates and configures

graphql/server-test/__tests__/upload.integration.test.ts

@@ -2,7 +2,7 @@
  * Upload Integration Tests — end-to-end presigned URL flow
  *
  * Exercises the full upload pipeline for both public and private files:
- *   requestUploadUrl → PUT to presigned URL → confirmUpload → downloadUrl
+ *   requestUploadUrl → PUT to presigned URL → downloadUrl
  *
  * Uses real MinIO (available in CI as minio_cdn service) and lazy bucket
  * provisioning. No RLS — that will be tested in constructive-db.
@@ -49,17 +49,6 @@ const REQUEST_UPLOAD_URL = `
       key
       deduplicated
       expiresAt
-      status
-    }
-  }
-`;
-
-const CONFIRM_UPLOAD = `
-  mutation ConfirmUpload($input: ConfirmUploadInput!) {
-    confirmUpload(input: $input) {
-      fileId
-      status
-      success
     }
   }
 `;
@@ -159,7 +148,6 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.key).toBe(contentHash);
       expect(payload.deduplicated).toBe(false);
       expect(payload.expiresAt).toBeTruthy();
-      expect(payload.status).toBe('pending');
 
       uploadUrl = payload.uploadUrl;
       fileId = payload.fileId;
@@ -169,23 +157,6 @@ describe('Upload integration (presigned URL flow)', () => {
       const putRes = await putToPresignedUrl(uploadUrl, fileContent, contentType);
       expect(putRes.ok).toBe(true);
     });
-
-    it('should confirm the upload and transition file to ready', async () => {
-      const res = await postGraphQL({
-        query: CONFIRM_UPLOAD,
-        variables: {
-          input: { fileId },
-        },
-      });
-
-      expect(res.status).toBe(200);
-      expect(res.body.errors).toBeUndefined();
-
-      const payload = res.body.data.confirmUpload;
-      expect(payload.fileId).toBe(fileId);
-      expect(payload.status).toBe('ready');
-      expect(payload.success).toBe(true);
-    });
   });
 
   describe('Private file upload', () => {
@@ -218,7 +189,6 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.key).toBe(contentHash);
       expect(payload.deduplicated).toBe(false);
       expect(payload.expiresAt).toBeTruthy();
-      expect(payload.status).toBe('pending');
 
       uploadUrl = payload.uploadUrl;
       fileId = payload.fileId;
@@ -228,23 +198,6 @@ describe('Upload integration (presigned URL flow)', () => {
       const putRes = await putToPresignedUrl(uploadUrl, fileContent, contentType);
       expect(putRes.ok).toBe(true);
     });
-
-    it('should confirm the upload and transition file to ready', async () => {
-      const res = await postGraphQL({
-        query: CONFIRM_UPLOAD,
-        variables: {
-          input: { fileId },
-        },
-      });
-
-      expect(res.status).toBe(200);
-      expect(res.body.errors).toBeUndefined();
-
-      const payload = res.body.data.confirmUpload;
-      expect(payload.fileId).toBe(fileId);
-      expect(payload.status).toBe('ready');
-      expect(payload.success).toBe(true);
-    });
   });
 
   describe('Deduplication', () => {
@@ -274,7 +227,6 @@ describe('Upload integration (presigned URL flow)', () => {
       expect(payload.uploadUrl).toBeNull();
       expect(payload.expiresAt).toBeNull();
       expect(payload.fileId).toBeTruthy();
-      expect(payload.status).toBe('ready');
     });
   });
 });