Merge pull request #405 from constructive-io/copilot/sub-pr-404

Add stack trace logging to error handlers in job workers

Author: Anmol1696

jobs/job-scheduler/src/index.ts

@@ -193,6 +193,9 @@ export default class Scheduler {
     ) => {
       if (err) {
         log.error('Error connecting with notify listener', err);
+        if (err instanceof Error && err.stack) {
+          log.debug(err.stack);
+        }
         // Try again in 5 seconds
         // should this really be done in the node process?
         setTimeout(this.listen, 5000);
@@ -207,7 +210,10 @@ export default class Scheduler {
       });
       client.query('LISTEN "scheduled_jobs:insert"');
       client.on('error', (e: unknown) => {
-        log.error('Error with database notify listener');
+        log.error('Error with database notify listener', e);
+        if (e instanceof Error && e.stack) {
+          log.debug(e.stack);
+        }
         release();
         this.listen();
       });

jobs/knative-job-worker/src/index.ts

@@ -176,7 +176,10 @@ export default class Worker {
       release: () => void
     ) => {
       if (err) {
-        log.error('Error connecting with notify listener');
+        log.error('Error connecting with notify listener', err);
+        if (err instanceof Error && err.stack) {
+          log.debug(err.stack);
+        }
         // Try again in 5 seconds
         // should this really be done in the node process?
         setTimeout(this.listen, 5000);
@@ -190,7 +193,10 @@ export default class Worker {
       });
       client.query('LISTEN "jobs:insert"');
       client.on('error', (e: unknown) => {
-        log.error('Error with database notify listener', String(e));
+        log.error('Error with database notify listener', e);
+        if (e instanceof Error && e.stack) {
+          log.debug(e.stack);
+        }
         release();
         this.listen();
       });

jobs/knative-job-worker/src/req.ts

@@ -67,6 +67,9 @@ const request = (
       function (error: unknown) {
         if (error) {
           log.error(`request error for job[${jobId}] fn[${fn}]`, error);
+          if (error instanceof Error && error.stack) {
+            log.debug(error.stack);
+          }
           return reject(error);
         }
         log.debug(`request success for job[${jobId}] fn[${fn}]`);