fix: pgvector should not trigger supplementary adapters like trgm

pgvector operates on embedding vectors, not text search. Add
isIntentionalSearch flag to SearchAdapter interface so that only
adapters representing real search infrastructure (tsvector, BM25)
trigger supplementary adapters. pgvector sets isIntentionalSearch: false.

Author: pyramation

graphile/graphile-search/src/adapters/pgvector.ts

@@ -52,6 +52,10 @@ export function createPgvectorAdapter(
 
     filterPrefix,
 
+    // pgvector operates on embedding vectors, not text search — its presence
+    // alone should NOT trigger supplementary adapters like trgm.
+    isIntentionalSearch: false,
+
     supportsTextSearch: false,
     // pgvector requires a vector array, not plain text — no buildTextSearchInput
 

graphile/graphile-search/src/plugin.ts

@@ -91,8 +91,12 @@ export function createUnifiedSearchPlugin(
    *
    * Runs non-supplementary adapters first (e.g. tsvector, BM25, pgvector).
    * Supplementary adapters (e.g. trgm with requireIntentionalSearch) are only
-   * run if at least one non-supplementary adapter found columns — this prevents
-   * trgm from adding similarity fields to every table with text columns.
+   * run if at least one adapter with `isIntentionalSearch: true` found columns.
+   *
+   * This distinction matters because pgvector (embeddings) is NOT intentional
+   * text search — its presence alone should not trigger trgm similarity fields.
+   * Only tsvector and BM25, which represent explicit search infrastructure,
+   * count as intentional search.
    */
   function getAdapterColumns(codec: PgCodecWithAttributes, build: any): AdapterColumnCache[] {
     const cacheKey = codec.name;
@@ -103,18 +107,25 @@ export function createUnifiedSearchPlugin(
     const primaryAdapters = adapters.filter((a) => !a.isSupplementary);
     const supplementaryAdapters = adapters.filter((a) => a.isSupplementary);
 
-    // Phase 1: Run non-supplementary (intentional search) adapters
+    // Phase 1: Run non-supplementary adapters (tsvector, BM25, pgvector, etc.)
     const results: AdapterColumnCache[] = [];
+    let hasIntentionalSearch = false;
     for (const adapter of primaryAdapters) {
       const columns = adapter.detectColumns(codec, build);
       if (columns.length > 0) {
         results.push({ adapter, columns });
+        // Track whether any "intentional search" adapter found columns.
+        // isIntentionalSearch defaults to true when not explicitly set.
+        if (adapter.isIntentionalSearch !== false) {
+          hasIntentionalSearch = true;
+        }
       }
     }
 
     // Phase 2: Only run supplementary adapters if at least one primary
-    // adapter found columns on this codec (i.e. intentional search exists)
-    if (results.length > 0) {
+    // adapter with isIntentionalSearch found columns on this codec.
+    // pgvector (isIntentionalSearch: false) alone won't trigger trgm.
+    if (hasIntentionalSearch) {
       for (const adapter of supplementaryAdapters) {
         const columns = adapter.detectColumns(codec, build);
         if (columns.length > 0) {

graphile/graphile-search/src/types.ts

@@ -77,16 +77,33 @@ export interface SearchAdapter {
 
   /**
    * When true, this adapter is "supplementary" — it only activates on
-   * tables that already have at least one column detected by a
-   * non-supplementary adapter (e.g. tsvector or BM25).
+   * tables that already have at least one column detected by an adapter
+   * whose `isIntentionalSearch` is true (e.g. tsvector or BM25).
    *
    * This prevents adapters like pg_trgm from adding similarity fields
    * to every table with text columns when there is no intentional search setup.
    *
+   * pgvector (embeddings) does NOT count as intentional search because it
+   * operates on vector columns, not text search — so its presence alone
+   * won't trigger supplementary adapters.
+   *
    * @default false
    */
   isSupplementary?: boolean;
 
+  /**
+   * When true, this adapter represents "intentional search" — its presence
+   * on a table signals that the table was explicitly set up for search and
+   * should trigger supplementary adapters (e.g. trgm).
+   *
+   * Adapters that check for real infrastructure (tsvector columns, BM25
+   * indexes) should set this to true. Adapters that operate on a different
+   * domain (pgvector embeddings) should set this to false.
+   *
+   * @default true
+   */
+  isIntentionalSearch?: boolean;
+
   /**
    * The filter prefix used for filter field names on the connection filter input.
    * The field name is: `{filterPrefix}{ColumnName}` (camelCase).