fix(types): remove = never default from FindFirstArgs TOrderBy param

pyramation · pyramation · commit d7aea8590862 · 2026-05-13T21:48:59.000Z
Since codegen always supplies a concrete TOrderBy type, a default is
unnecessary and misleading — never makes the orderBy field present
but unusable when the third type param is accidentally omitted.
diff --git a/graphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap b/graphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap
@@ -397,7 +397,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/graphql/codegen/src/core/codegen/orm/select-types.ts b/graphql/codegen/src/core/codegen/orm/select-types.ts
@@ -224,7 +224,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
 /**
  * Arguments for findFirst/findUnique operations
  */
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/graphql/codegen/src/core/codegen/templates/select-types.ts b/graphql/codegen/src/core/codegen/templates/select-types.ts
@@ -32,7 +32,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-cli/src/admin/orm/select-types.ts b/sdk/constructive-cli/src/admin/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-cli/src/auth/orm/select-types.ts b/sdk/constructive-cli/src/auth/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-cli/src/objects/orm/select-types.ts b/sdk/constructive-cli/src/objects/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-cli/src/public/orm/select-types.ts b/sdk/constructive-cli/src/public/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-react/src/admin/orm/select-types.ts b/sdk/constructive-react/src/admin/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-react/src/auth/orm/select-types.ts b/sdk/constructive-react/src/auth/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-react/src/objects/orm/select-types.ts b/sdk/constructive-react/src/objects/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-react/src/public/orm/select-types.ts b/sdk/constructive-react/src/public/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-sdk/src/admin/orm/select-types.ts b/sdk/constructive-sdk/src/admin/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-sdk/src/auth/orm/select-types.ts b/sdk/constructive-sdk/src/auth/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-sdk/src/objects/orm/select-types.ts b/sdk/constructive-sdk/src/objects/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/constructive-sdk/src/public/orm/select-types.ts b/sdk/constructive-sdk/src/public/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];
diff --git a/sdk/migrate-client/src/migrate/orm/select-types.ts b/sdk/migrate-client/src/migrate/orm/select-types.ts
@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
   offset?: number;
 }
 
-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {
+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {
   select?: TSelect;
   where?: TWhere;
   orderBy?: TOrderBy[];

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {`
`397`	`397`	`offset?: number;`
`398`	`398`	`}`
`399`	`399`
`400`		`-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {`
	`400`	`+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {`
`401`	`401`	`select?: TSelect;`
`402`	`402`	`where?: TWhere;`
`403`	`403`	`orderBy?: TOrderBy[];`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {`
`32`	`32`	`offset?: number;`
`33`	`33`	`}`
`34`	`34`
`35`		`-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {`
	`35`	`+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {`
`36`	`36`	`select?: TSelect;`
`37`	`37`	`where?: TWhere;`
`38`	`38`	`orderBy?: TOrderBy[];`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {`
`27`	`27`	`offset?: number;`
`28`	`28`	`}`
`29`	`29`
`30`		`-export interface FindFirstArgs<TSelect, TWhere, TOrderBy = never> {`
	`30`	`+export interface FindFirstArgs<TSelect, TWhere, TOrderBy> {`
`31`	`31`	`select?: TSelect;`
`32`	`32`	`where?: TWhere;`
`33`	`33`	`orderBy?: TOrderBy[];`