fix: remove non-existent 'size' column from upload_requests INSERTs#1013
Merged
pyramation merged 2 commits intomainfrom Apr 19, 2026
Merged
fix: remove non-existent 'size' column from upload_requests INSERTs#1013pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
The upload_requests table (generated by storage_module.sql) has no 'size' column — size only exists on the files table. The plugin was trying to INSERT size into upload_requests causing 'column size does not exist'. Also updates the test fixture's upload_requests table to match the actual generated schema: removes size, adds actor_id, ip_address, user_agent.
Missed the dedup path which had the same 'size' column issue in the upload_requests INSERT.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
upload_requeststable (generated bystorage_module.sqlin constructive-db) has nosizecolumn —sizeonly exists on thefilestable. The plugin was includingsizein both upload_requests INSERT paths (normal upload and dedup), causingcolumn "size" of relation "app_upload_requests" does not existat runtime.Plugin fix: Removes
sizefrom both INSERT statements and shifts the positional$Nparameters accordingly.Test fixture fix: Updates the
simple-seed-storageupload_requests CREATE TABLE to match the actual generated schema — removessize, adds missing columns (actor_id,ip_address,user_agent).Follow-up to PR #1012 which fixed
mime_type/content_hashmismatches on the files table. Both bugs originated from the plugin SQL being written against assumed column names rather than the actual generated schema.Review & Testing Checklist for Human
sizeshifted all$Nparams. Confirm the dedup path (5 columns → 5 values + 2 literals) and normal path (5 columns → 5 values + 1 literal + 1 param) are correctly alignedgraphql/server-test) end-to-end to confirm requestUploadUrl → PUT → confirmUpload still works with the corrected column listNotes
graphile-presigned-url-pluginneeds a version bump so constructive-db can pick up the fix via lockfile updateLink to Devin session: https://app.devin.ai/sessions/18879be982854a40abe5c9b915aa4a84
Requested by: @pyramation