feat(node-type-registry): centralize missing defaults in registry#1044
Merged
pyramation merged 1 commit intomainfrom May 2, 2026
Merged
feat(node-type-registry): centralize missing defaults in registry#1044pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
…ults in registry - AuthzRelatedPeerOwnership: add default 'id' to obj_ref_field - AuthzEntityMembership: add sel_field with default 'entity_id' - AuthzRelatedEntityMembership: add sel_field and sprt_join_field with default 'entity_id' These defaults were previously hardcoded in the cpt_* AST builder functions. Moving them to the registry makes it the single source of truth for all defaults.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing
defaultvalues to three Authz* node type definitions so that ALL defaults live in the registry as the single source of truth. Previously these defaults were hardcoded in thecpt_*AST builder functions in constructive-db.Changes:
obj_ref_field— adddefault: 'id'(was hardcoded incpt_related_peer_ownership)sel_fieldproperty withdefault: 'entity_id'(was hardcoded incpt_membership_by_field)sel_field(default: 'entity_id') andsprt_join_field(default: 'entity_id') (were hardcoded incpt_membership_by_join)This is part of centralizing all defaults — after this publishes, the corresponding COALESCE fallbacks in the constructive-db
cpt_*functions will be removed.Review & Testing Checklist for Human
policy_ast_builders.sqlNotes
Companion to constructive-db PRs #967 and #970 which implement the node_type_registry table and generic column cloning for issue #767.
Link to Devin session: https://app.devin.ai/sessions/20dbaaa0e6e74599842fbefe33efbc26
Requested by: @pyramation