feat(node-type-registry): complete column-ref annotations for all column-creating types#1048
Merged
pyramation merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
…umn-creating types - DataPublishable: add is_published_field, published_at_field - DataTimestamps: add created_at_field, updated_at_field - DataPeoplestamps: add created_by_field, updated_by_field - DataSoftDelete: add deleted_at_field, is_deleted_field - DataOwnershipInEntity: add owner_field_name, entity_field_name - DataJobTrigger: add column-ref to payload_custom additionalProperties - DataImageEmbedding: add column-ref to payload_custom additionalProperties - ViewAggregated: add column-ref to aggregates[].alias - Regenerate blueprint-types.generated.ts
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the
format: "column-ref"annotation work across the entire node-type-registry. Every node type that creates or references columns now has proper annotations.Types that previously hardcoded column names with no
parameter_schemaentry — now havecolumn-refproperties with defaults:DataPublishable:is_published_field(default"is_published"),published_at_field(default"published_at")DataTimestamps:created_at_field(default"created_at"),updated_at_field(default"updated_at")DataPeoplestamps:created_by_field(default"created_by"),updated_by_field(default"updated_by")DataSoftDelete:deleted_at_field(default"deleted_at"),is_deleted_field(default"is_deleted")DataOwnershipInEntity:owner_field_name(default"owner_id"),entity_field_name(default"entity_id")Existing string properties that referenced columns but lacked annotation:
DataJobTrigger.payload_custom.additionalProperties: values are column names (e.g.,{"invoice_id": "id", "total": "amount"})DataImageEmbedding.payload_custom.additionalProperties: same patternViewAggregated.aggregates[].alias: output column nameRegenerated
blueprint-types.generated.tsto include the new type definitions.Review & Testing Checklist for Human
table_module()dispatch in constructive-db) — e.g.,DataTimestampsSQL generator createscreated_at/updated_at, so defaults must match{}data remain valid)Notes
blueprint-types.generated.tswas regenerated vianpx ts-node src/codegen/generate-types.tsLink to Devin session: https://app.devin.ai/sessions/20dbaaa0e6e74599842fbefe33efbc26
Requested by: @pyramation