feat: adopt scope:fn naming convention for job task identifiers#1118
Closed
pyramation wants to merge 2 commits into
Closed
feat: adopt scope:fn naming convention for job task identifiers#1118pyramation wants to merge 2 commits into
pyramation wants to merge 2 commits into
Conversation
- Update all blueprint node defaults to use scoped task identifiers: - embed:process_file_embedding, embed:process_image_embedding - embed:generate_embedding, chunk:generate_chunks - Add scope-aware routing to knative-job-worker (parseScopedIdentifier, INTERNAL_GATEWAY_SCOPE_URLS env var for per-scope service routing) - Add scoped aliases to knative-job-service function registry - Update docker-compose files with scoped identifiers + backward compat - Document naming convention in jobs/README.md (Section 5)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
14 tasks
4 tasks
Combine scope routing infrastructure from this PR with the renamed function identifiers from PR #1124 (now on main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establishes a
scope:function_namenaming convention for all job task identifiers, enabling per-scope Knative service routing and independent autoscaling.Changes
Node-type-registry defaults — all blueprint node defaults now use scoped identifiers:
process_file_embedding→embed:process_file_embeddingprocess_image_embedding→embed:process_image_embeddinggenerate_embedding→embed:generate_embeddinggenerate_chunks→chunk:generate_chunksScope-aware routing (
job-utils+knative-job-worker):parseScopedIdentifier()andgetJobGatewayScopeUrls()tojob-utilsINTERNAL_GATEWAY_SCOPE_URLS→ (3) gateway fallbackknative-job-service: Added scoped aliases (
email:send_email_link,email:simple_email) in the function registry, pointing to the same implementations.Docker compose: Updated
JOBS_SUPPORTEDandINTERNAL_GATEWAY_DEVELOPMENT_MAPwith both scoped and legacy identifiers. AddedINTERNAL_GATEWAY_SCOPE_URLSfor per-scope service routing.Documentation: Added Section 5 "Task Identifier Naming Convention" to
jobs/README.mdwith the full identifier table, routing priority, and env var reference.Convention
email,embed,chunk,extract,sms)snake_caseReview & Testing Checklist for Human
scope:fnconvention makes sense for your deployment topology — each scope becomes an independently scalable Knative servicesend-email-link/simple-emailidentifiers still route correctly via the dev map fallbackINTERNAL_GATEWAY_SCOPE_URLSenv var pattern — this is the new production routing mechanismNotes
constructive-db(e.g.add_job('send-email-link', ...)) are unchanged — they'll need a follow-up PR in that repo to adopt scoped namesconstructive-dbas the source-of-truth for all job-queued functionsLink to Devin session: https://app.devin.ai/sessions/0bebbaeb3b374fd28f5ed051354b3b94
Requested by: @pyramation