ci: downsize pg/integration/ai test tiers from 4vcpu to 2vcpu#1406
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the
pg-tests,integration-tests, andai-teststiers inrun-tests.yamlfromblacksmith-4vcpu-ubuntu-2404toblacksmith-2vcpu-ubuntu-2404. On a recent main run these ~30 matrix jobs each spend only 1–21s in the actualTeststep — the ~45–60s of fixed setup (artifact download,pnpm install, Postgres tune/seed,fixtures:install) dominates. They are not CPU-bound, so 4vCPU is wasted spend; 2vCPU should roughly halve their cost with negligible wall-clock change.Also pins
NODE_OPTIONS=--max-old-space-size=4096on those tiers, since on smaller runners Node's memory-derived default heap can land near ~2GB and OOM Jest (observed in constructive-db's equivalent experiment).Unchanged:
buildandunit-testsstay onubuntu-latest.Follow-up worth considering (not in this PR): the many tiny pg/integration jobs each re-pay ~45s of fixed overhead; batching them (like the
unit-teststier already does) would cut cost further than runner sizing alone.Link to Devin session: https://app.devin.ai/sessions/180599d6e0c1419994599efb1eabd9b5
Requested by: @pyramation