ci: batch pg/integration test jobs + faster container health-checks#1408
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the runner-downsizing PR. Measured on a recent
run-tests.yamlmain run, each pg/integration/ai matrix job spends only ~6s in its actualTeststep but ~48s in fixed overhead — "Initialize containers" alone is ~25s/job (47%). So we were paying per-job service-container + install overhead ~30 times over.Two changes:
Batch the per-package matrix jobs, mirroring the existing
unit-teststier (one job runs several packages' tests sequentially against one shared service container):pg-tests: 19 jobs → 3 (pg-core,pg-postgres,pg-graphql)integration-tests: 10 jobs → 2 (integration-graphql,integration-uploads)env(TEST_DATABASE_URL,BUCKET_NAME) is hoisted to the job-levelenv— harmless for packages that ignore it.Tighten service-container health-checks
--health-interval 10s → 3s(retries 5 → 10) for Postgres/MinIO across all three tiers. A container that's ready in ~2s previously wasn't marked healthy until the first 10s poll, wasting ~7s/job.Net: ~29 DB jobs → ~5, removing ~24× the ~48s fixed overhead (plus the health-check savings on what remains). Test coverage is unchanged — same packages, just grouped.
unit-tests(no services) andbuildare untouched.Link to Devin session: https://app.devin.ai/sessions/180599d6e0c1419994599efb1eabd9b5
Requested by: @pyramation