Rename fullTextSearch composite filter to unifiedSearch#956
Merged
pyramation merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Rename the composite GraphQL filter field from fullTextSearch to unifiedSearch across the plugin, codegen, tests, and skills to disambiguate it from the tsvector-specific fullTextSearchTsv filter. - Plugin: rename field, config option enableFullTextSearch → enableUnifiedSearch - Codegen: update CLI example docs in docs-utils.ts - Tests: update all GraphQL queries and assertions - Skills: update CLI examples in user.md references The full_text_search metaschema DB table and tsvector adapter naming (fullTextSearchTsv, filterPrefix) are intentionally left unchanged.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration Bot
pushed a commit
to constructive-io/constructive-skills
that referenced
this pull request
Apr 2, 2026
Update all references to the composite GraphQL filter field from fullTextSearch to unifiedSearch across graphile-search, constructive-graphql, and constructive-ai skills documentation. TSVector-specific references (fullTextSearchTsv, filterPrefix, etc.) and metaschema table references (db.fullTextSearch.create(), full_text_search table) are intentionally left unchanged. Companion to constructive-io/constructive#956.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the composite GraphQL filter field from
fullTextSearchtounifiedSearchto disambiguate it from the tsvector-specificfullTextSearchTsvper-adapter filter. The composite filter fans out a single text query to all text-compatible search adapters (tsvector, BM25, trgm) simultaneously — calling it "unified search" better describes what it does.What changed:
graphile-search): field namefullTextSearch→unifiedSearch, config optionenableFullTextSearch→enableUnifiedSearchdocs-utils.ts): CLI example docs updated (--where.unifiedSearch)cli-publicandcli-authuser referencesWhat was intentionally left unchanged:
full_text_searchmetaschema DB table and all its generated SDK/ORM/CLI CRUD operationsfilterPrefix: 'fullTextSearch'(producingfullTextSearchTsv)fullTextSearchesinput onprovisionTablefullTextSearchor configs usingenableFullTextSearchwill need to update.Review & Testing Checklist for Human
search.integration.test.ts(around lines 341-344, 475-480) andcli-e2e.test.ts(around lines 910-921) introduced inconsistent indentation relative to surrounding code. Verify these don't cause lint failures and fix if needed.fullTextSearchreferences remain in plugin source: Rungrep -r fullTextSearch graphile/graphile-search/src/— should return zero hits (the tsvector adapter'sfilterPrefixis defined elsewhere).fullTextSearchdirectly — this is a breaking rename with no deprecation shim.constructive-io/constructive-skillsto update the same references there.Suggested test plan: Run the graphile-search unit tests (
cd graphile/graphile-search && pnpm test) and the server integration tests (cd graphql/server-test && pnpm test) to confirm the renamed field is correctly wired end-to-end.Notes
constructive-skillsexternal repo update is planned as a separate PR.full_text_search.mdskill reference files (describing the metaschema table CRUD) are correctly left untouched — those refer to the DB table, not the composite GraphQL filter.Link to Devin session: https://app.devin.ai/sessions/e35003b7898c437e8d69a0c70b6020f2
Requested by: @pyramation