Skip to content

Rename fullTextSearch composite filter to unifiedSearch#956

Merged
pyramation merged 1 commit intomainfrom
devin/1775105159-rename-fullTextSearch-to-unifiedSearch
Apr 2, 2026
Merged

Rename fullTextSearch composite filter to unifiedSearch#956
pyramation merged 1 commit intomainfrom
devin/1775105159-rename-fullTextSearch-to-unifiedSearch

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

Summary

Renames the composite GraphQL filter field from fullTextSearch to unifiedSearch to disambiguate it from the tsvector-specific fullTextSearchTsv per-adapter filter. The composite filter fans out a single text query to all text-compatible search adapters (tsvector, BM25, trgm) simultaneously — calling it "unified search" better describes what it does.

What changed:

  • Plugin (graphile-search): field name fullTextSearchunifiedSearch, config option enableFullTextSearchenableUnifiedSearch
  • Codegen (docs-utils.ts): CLI example docs updated (--where.unifiedSearch)
  • Tests: all GraphQL queries and assertions updated across 4 test files
  • In-repo skills: CLI examples in cli-public and cli-auth user references

What was intentionally left unchanged:

  • The full_text_search metaschema DB table and all its generated SDK/ORM/CLI CRUD operations
  • The tsvector adapter's filterPrefix: 'fullTextSearch' (producing fullTextSearchTsv)
  • The fullTextSearches input on provisionTable

⚠️ Breaking change: Existing GraphQL queries using fullTextSearch or configs using enableFullTextSearch will need to update.

Review & Testing Checklist for Human

  • Indentation consistency in test files: The edits to search.integration.test.ts (around lines 341-344, 475-480) and cli-e2e.test.ts (around lines 910-921) introduced inconsistent indentation relative to surrounding code. Verify these don't cause lint failures and fix if needed.
  • No stray fullTextSearch references remain in plugin source: Run grep -r fullTextSearch graphile/graphile-search/src/ — should return zero hits (the tsvector adapter's filterPrefix is defined elsewhere).
  • Downstream consumers: Confirm no other internal services or deployed apps query fullTextSearch directly — this is a breaking rename with no deprecation shim.
  • External skills repo: A follow-up PR is needed for constructive-io/constructive-skills to update the same references there.

Suggested test plan: Run the graphile-search unit tests (cd graphile/graphile-search && pnpm test) and the server integration tests (cd graphql/server-test && pnpm test) to confirm the renamed field is correctly wired end-to-end.

Notes

  • The constructive-skills external repo update is planned as a separate PR.
  • The full_text_search.md skill reference files (describing the metaschema table CRUD) are correctly left untouched — those refer to the DB table, not the composite GraphQL filter.

Link to Devin session: https://app.devin.ai/sessions/e35003b7898c437e8d69a0c70b6020f2
Requested by: @pyramation

Rename the composite GraphQL filter field from fullTextSearch to
unifiedSearch across the plugin, codegen, tests, and skills to
disambiguate it from the tsvector-specific fullTextSearchTsv filter.

- Plugin: rename field, config option enableFullTextSearch → enableUnifiedSearch
- Codegen: update CLI example docs in docs-utils.ts
- Tests: update all GraphQL queries and assertions
- Skills: update CLI examples in user.md references

The full_text_search metaschema DB table and tsvector adapter naming
(fullTextSearchTsv, filterPrefix) are intentionally left unchanged.
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration Bot pushed a commit to constructive-io/constructive-skills that referenced this pull request Apr 2, 2026
Update all references to the composite GraphQL filter field from
fullTextSearch to unifiedSearch across graphile-search, constructive-graphql,
and constructive-ai skills documentation.

TSVector-specific references (fullTextSearchTsv, filterPrefix, etc.) and
metaschema table references (db.fullTextSearch.create(), full_text_search
table) are intentionally left unchanged.

Companion to constructive-io/constructive#956.
@pyramation pyramation merged commit dc0114f into main Apr 2, 2026
46 checks passed
@pyramation pyramation deleted the devin/1775105159-rename-fullTextSearch-to-unifiedSearch branch April 2, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant