Merge pull request #4 from constructive-io/feat/clean-retry

fix: add maxRetries to fs.rm in clean to handle ENOTEMPTY race conditions

Author: pyramation

packages/makage/__tests__/clean.test.ts

@@ -14,20 +14,20 @@ describe('runClean', () => {
   it('should remove a single path', async () => {
     await runClean(['dist']);
 
-    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true });
+    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
   });
 
   it('should remove multiple paths', async () => {
     await runClean(['dist', 'build', 'temp']);
 
-    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true });
-    expect(mockedFs.rm).toHaveBeenCalledWith('build', { recursive: true, force: true });
-    expect(mockedFs.rm).toHaveBeenCalledWith('temp', { recursive: true, force: true });
+    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
+    expect(mockedFs.rm).toHaveBeenCalledWith('build', { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
+    expect(mockedFs.rm).toHaveBeenCalledWith('temp', { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
   });
 
   it('should default to "dist" if no paths provided', async () => {
     await runClean([]);
 
-    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true });
+    expect(mockedFs.rm).toHaveBeenCalledWith('dist', { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
   });
 });

packages/makage/src/commands/clean.ts

@@ -4,7 +4,7 @@ export async function runClean(paths: string[]) {
   const pathsToClean = paths.length ? paths : ['dist'];
 
   for (const p of pathsToClean) {
-    await fs.rm(p, { recursive: true, force: true });
+    await fs.rm(p, { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
     console.log(`[makage] removed ${p}`);
   }
 }