feat: scan all package.json files in non-workspace target repos#6
Merged
Merged
Conversation
update-deps --in now recursively discovers all package.json files when the target repo has no pnpm-workspace.yaml, instead of only checking the root. This enables dependency detection in boilerplate repos like sandbox-templates and pgpm-boilerplates that have multiple independent template dirs with their own package.json files.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
makage update-deps --in <target>to recursively discover allpackage.jsonfiles when the target repo has nopnpm-workspace.yaml, instead of only checking the rootpackage.json.This enables dependency detection in boilerplate/template repos like
sandbox-templatesandpgpm-boilerplates, which have multiple independent template directories each with their ownpackage.json(and sometimes their own lockfile) but no pnpm workspace configuration.Before: non-workspace targets only checked
package.jsonat the repo root.After: non-workspace targets glob for
**/package.json(excludingnode_modules), discovering all nested templates.Review & Testing Checklist for Human
glob('**/package.json')from thegloblibrary matches the rootpackage.jsonas well (unlike git pathspecs where**only matches subdirectories). If it doesn't, the root would be silently skipped in non-workspace repos.makage update-deps --from ./constructive --in ./sandbox-templatesandmakage update-deps --from ./constructive --in ./pgpm-boilerplatesto confirm nested templates are discovered and outdated deps are detected.package.jsonfiles in unexpected places (test fixtures, examples, etc.) could cause false matches. Currently onlynode_modulesis excluded.Notes
pnpm-workspace.yaml) are unaffected — the existing workspace-aware path is tried first.update-constructive-depsworkflow.Link to Devin session: https://app.devin.ai/sessions/08781f0838fd4c929bb5ab08052b2b5a
Requested by: @pyramation