Fix walk function to traverse WithClause and union larg/rarg nodes#232
Closed
pyramation wants to merge 1 commit intomainfrom
Closed
Fix walk function to traverse WithClause and union larg/rarg nodes#232pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
- Modified walk function to check if field type is any node type (not just 'Node') - Added logic to use schemaMap to determine if a field type is a node - Added test cases for WithClause traversal - Added test cases for union larg/rarg traversal - Fixes #216 Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix walk function to traverse WithClause and union larg/rarg nodes
Summary
Fixes #216 by updating the
walkfunction in the traverse package to properly handle fields with specific node types (likeWithClause,SelectStmt) instead of only traversing fields explicitly marked as type'Node'.The Problem: The walk function was only traversing fields where
field.type === 'Node', but some fields in the runtime schema have specific types like'WithClause'or'SelectStmt'. This caused the traversal to skip:withClausefields (type:'WithClause')largandrargfields in union operations (type:'SelectStmt')The Solution: Modified the traversal logic to check if a field's type exists in the
schemaMap(meaning it's a valid node type), not just if it's explicitly'Node'. This allows traversal of all 268 node types defined in the schema.Changes:
packages/traverse/src/traverse.tsto checkschemaMap.has(field.type)in addition tofield.type === 'Node'Review & Testing Checklist for Human
Test Plan
Notes