Exquisite Corpse #8
Open
LemonyDesign wants to merge 15 commits into
Open
Conversation
| } | ||
|
|
||
| addFavourites(corpseitem) { | ||
| this.setState({ |
Contributor
There was a problem hiding this comment.
rather than using a callback here, it would be better to use
const favourites = this.state.favourites.concat(corpseitem);
this.setState({
favourites: favourites
});
window.localStorage.setItem('favourites', favourites);
| } | ||
|
|
||
| removeFromFavourites(corpseitem) { | ||
| const filteredFavourites = this.state.favourites.filter(currentFavourite => { |
|
|
||
| const favouriteclasses = cx('workshop__favourite', { | ||
| 'active': this.state.active, | ||
| '': !this.state.active |
Contributor
There was a problem hiding this comment.
I don't think this line is needed as it will insert nothing in both cases
| function Generate({receiveType, typeresult1, typeresult2, favourites, addFavourites, removeFromFavourites}) { | ||
|
|
||
| function handleChange1(event) { | ||
| receiveType(event.target.value, 'type1'); |
Contributor
There was a problem hiding this comment.
I wonder if type1 and type2 could have more descriptive names as they seem a bit vague
|
|
||
| const corpsesclasses = cx('generate__corpses menu--settings', { | ||
| 'active': notEmpty && sameLength, | ||
| '': !(notEmpty && sameLength) |
Contributor
There was a problem hiding this comment.
I don't think this line needed. It does not add any classes
Contributor
|
Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In development…