Skip to content

Commit 1adac7a

Browse files
authored
Merge pull request #12 from unv-unv/java-class-names-to-common-class-names
Replacing JavaClassNames with CommonClassNames
2 parents d248623 + beb6060 commit 1adac7a

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

plugin/src/main/java/org/jetbrains/plugins/gradle/service/resolve/GradleResolverUtil.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818
import com.intellij.java.language.psi.*;
1919
import consulo.annotation.access.RequiredReadAction;
2020
import consulo.application.util.RecursionManager;
21-
import consulo.java.language.module.util.JavaClassNames;
2221
import consulo.language.psi.PsiElement;
2322
import consulo.language.psi.resolve.PsiScopeProcessor;
2423
import consulo.language.psi.resolve.ResolveState;
2524
import consulo.language.psi.util.PsiTreeUtil;
25+
import jakarta.annotation.Nonnull;
26+
import jakarta.annotation.Nullable;
2627
import org.jetbrains.plugins.gradle.util.GradleLog;
2728
import org.jetbrains.plugins.groovy.lang.parser.GroovyElementTypes;
2829
import org.jetbrains.plugins.groovy.lang.psi.GroovyFile;
@@ -40,8 +41,6 @@
4041
import org.jetbrains.plugins.groovy.lang.psi.util.GroovyCommonClassNames;
4142
import org.jetbrains.plugins.groovy.lang.psi.util.GroovyPropertyUtils;
4243

43-
import jakarta.annotation.Nonnull;
44-
import jakarta.annotation.Nullable;
4544
import java.util.Arrays;
4645

4746
/**
@@ -66,6 +65,7 @@ public static int getGrMethodArumentsCount(@Nonnull GrArgumentList args) {
6665
return argsCount;
6766
}
6867

68+
@RequiredReadAction
6969
public static void addImplicitVariable(
7070
@Nonnull PsiScopeProcessor processor,
7171
@Nonnull ResolveState state,
@@ -118,15 +118,15 @@ public static GrLightMethodBuilder createMethodWithClosure(
118118
}
119119
else {
120120
PsiClassType closureClassTypeParameter =
121-
factory.createTypeByFQClassName(JavaClassNames.JAVA_LANG_OBJECT, place.getResolveScope());
121+
factory.createTypeByFQClassName(CommonClassNames.JAVA_LANG_OBJECT, place.getResolveScope());
122122
closureType = factory.createType(closureClass, closureClassTypeParameter);
123123
}
124124

125125
GrLightMethodBuilder methodWithClosure = new GrLightMethodBuilder(place.getManager(), name);
126126
GrLightParameter closureParameter = new GrLightParameter("closure", closureType, methodWithClosure);
127127
methodWithClosure.addParameter(closureParameter);
128128
PsiClassType retType = factory.createTypeByFQClassName(
129-
returnType != null ? returnType : JavaClassNames.JAVA_LANG_OBJECT,
129+
returnType != null ? returnType : CommonClassNames.JAVA_LANG_OBJECT,
130130
place.getResolveScope()
131131
);
132132
methodWithClosure.setReturnType(retType);
@@ -154,9 +154,9 @@ public static void processMethod(
154154
) {
155155
GrLightMethodBuilder builder = new GrLightMethodBuilder(place.getManager(), methodName);
156156
PsiElementFactory factory = JavaPsiFacade.getElementFactory(place.getManager().getProject());
157-
PsiType type = new PsiArrayType(factory.createTypeByFQClassName(JavaClassNames.JAVA_LANG_OBJECT, place.getResolveScope()));
157+
PsiType type = new PsiArrayType(factory.createTypeByFQClassName(CommonClassNames.JAVA_LANG_OBJECT, place.getResolveScope()));
158158
builder.addParameter(new GrLightParameter("param", type, builder));
159-
PsiClassType retType = factory.createTypeByFQClassName(JavaClassNames.JAVA_LANG_OBJECT, place.getResolveScope());
159+
PsiClassType retType = factory.createTypeByFQClassName(CommonClassNames.JAVA_LANG_OBJECT, place.getResolveScope());
160160
builder.setReturnType(retType);
161161
processor.execute(builder, state);
162162

plugin/src/main/java/org/jetbrains/plugins/gradle/service/resolve/GradleTaskContributor.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@
1717

1818
import com.intellij.java.language.impl.psi.impl.source.PsiImmediateClassType;
1919
import com.intellij.java.language.psi.*;
20+
import consulo.annotation.access.RequiredReadAction;
2021
import consulo.annotation.component.ExtensionImpl;
21-
import consulo.java.language.module.util.JavaClassNames;
2222
import consulo.language.psi.PsiElement;
2323
import consulo.language.psi.resolve.PsiScopeProcessor;
2424
import consulo.language.psi.resolve.ResolveState;
2525
import consulo.language.psi.util.PsiTreeUtil;
2626
import consulo.util.lang.StringUtil;
27+
import jakarta.annotation.Nonnull;
2728
import org.jetbrains.plugins.groovy.lang.psi.GroovyPsiElement;
2829
import org.jetbrains.plugins.groovy.lang.psi.api.statements.arguments.GrArgumentList;
2930
import org.jetbrains.plugins.groovy.lang.psi.api.statements.arguments.GrNamedArgument;
@@ -35,7 +36,6 @@
3536
import org.jetbrains.plugins.groovy.lang.psi.impl.synthetic.GrLightMethodBuilder;
3637
import org.jetbrains.plugins.groovy.lang.psi.impl.synthetic.GrLightParameter;
3738

38-
import jakarta.annotation.Nonnull;
3939
import java.util.List;
4040

4141
/**
@@ -45,6 +45,7 @@
4545
@ExtensionImpl
4646
public class GradleTaskContributor implements GradleMethodContextContributor {
4747
@Override
48+
@RequiredReadAction
4849
public void process(
4950
@Nonnull List<String> methodCallInfo,
5051
@Nonnull PsiScopeProcessor processor,
@@ -140,9 +141,9 @@ private static void processTaskAddition(
140141

141142
GrLightMethodBuilder builder = new GrLightMethodBuilder(place.getManager(), name);
142143
PsiElementFactory factory = JavaPsiFacade.getElementFactory(place.getManager().getProject());
143-
PsiType type = new PsiArrayType(factory.createTypeByFQClassName(JavaClassNames.JAVA_LANG_OBJECT, place.getResolveScope()));
144+
PsiType type = new PsiArrayType(factory.createTypeByFQClassName(CommonClassNames.JAVA_LANG_OBJECT, place.getResolveScope()));
144145
builder.addParameter(new GrLightParameter("taskInfo", type, builder));
145-
PsiClassType retType = factory.createTypeByFQClassName(JavaClassNames.JAVA_LANG_STRING, place.getResolveScope());
146+
PsiClassType retType = factory.createTypeByFQClassName(CommonClassNames.JAVA_LANG_STRING, place.getResolveScope());
146147
builder.setReturnType(retType);
147148
processor.execute(builder, state);
148149

0 commit comments

Comments
 (0)