Skip to content

Commit 7a0cd06

Browse files
committed
fix using getInstance() instead ID
1 parent b6e2982 commit 7a0cd06

13 files changed

Lines changed: 22 additions & 33 deletions

File tree

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/compiler/GroovyCompilerBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ protected void runGroovycCompiler(CompileContext compileContext,
112112

113113
Library[] libraries = GroovyConfigUtils.getInstance().getSDKLibrariesByModule(module);
114114
if (libraries.length > 0) {
115-
classPathBuilder.addVirtualFiles(Arrays.asList(libraries[0].getFiles(BinariesOrderRootType.getInstance())));
115+
classPathBuilder.addVirtualFiles(Arrays.asList(libraries[0].getFiles(BinariesOrderRootType.ID)));
116116
}
117117

118118
JavaSdkType javaSdkType = (JavaSdkType)sdk.getSdkType();

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/config/GroovyLibraryPresentationProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public boolean isSDKHome(@Nonnull VirtualFile file) {
6969
protected void fillLibrary(String path, LibraryEditor libraryEditor) {
7070
File srcRoot = new File(path + "/src/main");
7171
if (srcRoot.exists()) {
72-
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(srcRoot), SourcesOrderRootType.getInstance());
72+
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(srcRoot), SourcesOrderRootType.ID);
7373
}
7474

7575
File[] jars;
@@ -83,7 +83,7 @@ protected void fillLibrary(String path, LibraryEditor libraryEditor) {
8383
if (jars != null) {
8484
for (File file : jars) {
8585
if (file.getName().endsWith(".jar")) {
86-
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(file), BinariesOrderRootType.getInstance());
86+
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(file), BinariesOrderRootType.ID);
8787
}
8888
}
8989
}

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/grape/GrabDependencies.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,11 @@ private void addGrapeDependencies(List<VirtualFile> jars) {
298298
for (VirtualFile jar : jars) {
299299
VirtualFile jarRoot = ArchiveVfsUtil.getJarRootForLocalFile(jar);
300300
if (jarRoot != null) {
301-
OrderRootType rootType = BinariesOrderRootType.getInstance();
301+
String rootType = BinariesOrderRootType.ID;
302302
String libName = "Grab:" + jar.getName();
303303
for (String classifier : List.of("sources", "source", "src")) {
304304
if (libName.endsWith("-" + classifier + ".jar")) {
305-
rootType = SourcesOrderRootType.getInstance();
305+
rootType = SourcesOrderRootType.ID;
306306
libName = StringUtil.trimEnd(libName, "-" + classifier + ".jar") + ".jar";
307307
}
308308
}

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/griffon/GriffonFramework.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ public File getDefaultSdkWorkDir(@Nonnull Module module) {
398398

399399
@Override
400400
public boolean isSDKLibrary(Library library) {
401-
return GriffonLibraryPresentationProvider.isGriffonSdk(library.getFiles(BinariesOrderRootType.getInstance()));
401+
return GriffonLibraryPresentationProvider.isGriffonSdk(library.getFiles(BinariesOrderRootType.ID));
402402
}
403403

404404
@Override

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/griffon/GriffonLibraryPresentationProvider.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ protected void fillLibrary(String path, LibraryEditor libraryEditor) {
5757
if (jars != null) {
5858
for (String fileName : jars) {
5959
if (fileName.endsWith(".jar")) {
60-
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(new File(path + ("/dist/") + fileName)), BinariesOrderRootType.getInstance());
60+
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(new File(path + ("/dist/") + fileName)), BinariesOrderRootType.ID);
6161
}
6262
}
6363
}
@@ -66,7 +66,7 @@ protected void fillLibrary(String path, LibraryEditor libraryEditor) {
6666
if (jars != null) {
6767
for (String fileName : jars) {
6868
if (fileName.endsWith(".jar")) {
69-
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(new File(path + "/lib/" + fileName)), BinariesOrderRootType.getInstance());
69+
libraryEditor.addRoot(VirtualFileUtil.getUrlForLibraryRoot(new File(path + "/lib/" + fileName)), BinariesOrderRootType.ID);
7070
}
7171
}
7272
}
@@ -123,7 +123,7 @@ public static boolean isGriffonSdk(VirtualFile[] files) {
123123
public static String getGriffonVersion(@Nonnull Module module) {
124124
for (OrderEntry orderEntry : ModuleRootManager.getInstance(module).getOrderEntries()) {
125125
if (orderEntry instanceof LibraryOrderEntry) {
126-
VirtualFile[] files = orderEntry.getFiles(BinariesOrderRootType.getInstance());
126+
VirtualFile[] files = orderEntry.getFiles(BinariesOrderRootType.ID);
127127
if (isGriffonSdk(files)) {
128128
return getGriffonVersion(files);
129129
}

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/ivy/AbstractAttachSourceProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ protected static Library getLibraryFromOrderEntriesList(List<LibraryOrderEntry>
6969

7070
protected void addSourceFile(@Nullable VirtualFile jarRoot, @Nonnull Library library) {
7171
if (jarRoot != null) {
72-
if (!Arrays.asList(library.getFiles(SourcesOrderRootType.getInstance())).contains(jarRoot)) {
72+
if (!Arrays.asList(library.getFiles(SourcesOrderRootType.ID)).contains(jarRoot)) {
7373
Library.ModifiableModel model = library.getModifiableModel();
74-
model.addRoot(jarRoot, SourcesOrderRootType.getInstance());
74+
model.addRoot(jarRoot, SourcesOrderRootType.ID);
7575
model.commit();
7676
}
7777
}

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/ivy/IvyAttachSourceProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public Collection<AttachSourcesAction> getActions(List<LibraryOrderEntry> orderE
8383
if (srcFile != null) {
8484
// File already downloaded.
8585
VirtualFile jarRoot = ArchiveVfsUtil.getJarRootForLocalFile(srcFile);
86-
if (jarRoot == null || ArrayUtil.contains(jarRoot, library.getFiles(SourcesOrderRootType.getInstance()))) {
86+
if (jarRoot == null || ArrayUtil.contains(jarRoot, library.getFiles(SourcesOrderRootType.ID))) {
8787
return Collections.emptyList(); // Sources already attached.
8888
}
8989

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/mvc/MvcFramework.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ protected List<File> getImplicitClasspathRoots(@Nonnull Module module) {
297297

298298
Library library = MvcModuleStructureUtil.findUserLibrary(module, getUserLibraryName());
299299
if (library != null) {
300-
for (VirtualFile file : library.getFiles(BinariesOrderRootType.getInstance())) {
300+
for (VirtualFile file : library.getFiles(BinariesOrderRootType.ID)) {
301301
toExclude.add(VirtualFileUtil.virtualToIoFile(VirtualFilePathUtil.getLocalFile(file)));
302302
}
303303
}

groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/mvc/MvcModuleStructureUtil.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ public static void cleanupDefaultLibrary(Module module,
405405

406406
final List<String> toRemoveUrls = new ArrayList<String>();
407407

408-
for (String url : library.getUrls(BinariesOrderRootType.getInstance())) {
408+
for (String url : library.getUrls(BinariesOrderRootType.ID)) {
409409
VirtualFile virtualFile = virtualFileManager.findFileByUrl(url);
410410

411411
if (virtualFile == null) {
@@ -426,7 +426,7 @@ public static void cleanupDefaultLibrary(Module module,
426426
public void accept(ModifiableRootModel model) {
427427
Library.ModifiableModel modifiableModel = modifyDefaultLibrary(model, libName);
428428
for (String url : toRemoveUrls) {
429-
modifiableModel.removeRoot(url, BinariesOrderRootType.getInstance());
429+
modifiableModel.removeRoot(url, BinariesOrderRootType.ID);
430430
}
431431
modifiableModel.commit();
432432
}
@@ -490,7 +490,7 @@ private static Set<String> getJarUrls(@Nullable Library library) {
490490

491491
Set<String> res = new HashSet<String>();
492492

493-
for (String url : library.getUrls(BinariesOrderRootType.getInstance())) {
493+
for (String url : library.getUrls(BinariesOrderRootType.ID)) {
494494
if (!library.isJarDirectory(url)) {
495495
res.add(url);
496496
}
@@ -721,16 +721,16 @@ public static void copyUserLibraries(ModuleRootModel from, ModifiableRootModel t
721721
}
722722

723723
Library.ModifiableModel model = userLibraryTo.getModifiableModel();
724-
for (String url : model.getUrls(BinariesOrderRootType.getInstance())) {
724+
for (String url : model.getUrls(BinariesOrderRootType.ID)) {
725725
if (!model.isJarDirectory(url)) {
726-
model.removeRoot(url, BinariesOrderRootType.getInstance());
726+
model.removeRoot(url, BinariesOrderRootType.ID);
727727
}
728728
}
729729

730730
if (userLibraryFrom != null) {
731-
for (String url : userLibraryFrom.getUrls(BinariesOrderRootType.getInstance())) {
731+
for (String url : userLibraryFrom.getUrls(BinariesOrderRootType.ID)) {
732732
if (!userLibraryFrom.isJarDirectory(url)) {
733-
model.addRoot(url, BinariesOrderRootType.getInstance());
733+
model.addRoot(url, BinariesOrderRootType.ID);
734734
}
735735
}
736736
}

groovy-psi/src/main/java/org/jetbrains/plugins/groovy/config/GroovyConfigUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public boolean isSDKLibrary(Library library) {
109109
if (library == null) {
110110
return false;
111111
}
112-
return LibrariesUtil.getGroovyLibraryHome(library.getFiles(BinariesOrderRootType.getInstance())) != null;
112+
return LibrariesUtil.getGroovyLibraryHome(library.getFiles(BinariesOrderRootType.ID)) != null;
113113
}
114114

115115
@Nullable

0 commit comments

Comments
 (0)