chore: upgrade golang to 1.26#344
Merged
Merged
Conversation
northtyphoon
force-pushed
the
update-golang
branch
from
February 11, 2026 19:59
7120803 to
4075016
Compare
Signed-off-by: Bin Du <bindu@microsoft.com>
northtyphoon
force-pushed
the
update-golang
branch
from
February 11, 2026 20:03
4075016 to
e9d8229
Compare
estebanreyl
reviewed
Feb 12, 2026
estebanreyl
left a comment
estebanreyl
left a comment
Member
There was a problem hiding this comment.
LGTM but I am assuming we need to update the dependencies as well
| module github.com/containerd/accelerated-container-image/ci/e2e | ||
|
|
||
| go 1.23.0 | ||
| go 1.26.0 |
Member
There was a problem hiding this comment.
If the version is increasing, we should probably do a go mod tidy to upgrade the dependencies as well
Contributor
Author
There was a problem hiding this comment.
I ran the go mod tidy and go mod vendor. there is no change in go.sum
Member
|
LGTM, thanks |
4 tasks
AkihiroSuda
reviewed
Apr 2, 2026
| ## Requirements | ||
|
|
||
| * Install Go >= 1.23.x | ||
| * Install Go >= 1.26.x |
Member
There was a problem hiding this comment.
Why drop support for Go 1.25?
Contributor
There was a problem hiding this comment.
FWIW, Flatcar packages this project but wasn't ready to take 1.26, so we just patched it to 1.25 and nothing bad happened.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update golang to 1.26 as 1.23 support has ended
Please check the following list: