Tear down networks in reverse of configured order#137
Open
jronak wants to merge 1 commit into
Open
Conversation
libcni.Remove iterated c.networks in the same order they were configured (FIFO). The CNI spec expects teardown to run in reverse of setup; iterate c.networks in reverse on Remove to match. Add a regression test covering the new ordering. Signed-off-by: ronakj <ronakjainc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removecurrently tears down networks in the same order they were configured. This means a config loaded asWithLoNetwork, WithDefaultConfruns loopbackDELbefore the user-defined networkDEL.The CNI spec tears down plugin chains in reverse order, and the same rule should apply here: networks added earlier should stay available while later networks are being removed. In practice this keeps
loup until user-defined plugins have finished their cleanup. This changesRemoveto iteratec.networksin reverse order and adds a regression test for the ordering.Signed-off-by: ronakj ronakjainc@gmail.com