Clear decrypted layers cache more agressively in local keys tests#215
Merged
Conversation
Set the environment variable OCICRYPT_CONFIG=internal when starting containerd so that the ctd-decoder tool knows which PKCS11 config to use when started from containerd. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Add calls to remove_all_snaphots in local keys tests to avoid decrypted layers caching effects. This now requires an update of the ocicrypt library for the test to work since previously cached layers were used and no actual decryption was done when pkcs11 was used. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the code to implement new remove_all_snapshots function and use it to aggressively clear the layer cache. It shows that the pkcs11 local keys test did not actually decrypt the layers when creating a container but it relied on cached layers instead. An updated version of the ocicrypt library is therefore needed.