Skip to content

Commit 3a884b1

Browse files
committed
tracing: remove dead code, update docs
1 parent ed1e0b8 commit 3a884b1

2 files changed

Lines changed: 18 additions & 24 deletions

File tree

docs/tracing.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
# OTel Tracing
1+
# Tracing
22

3-
Nerdbox supports OpenTelemetry tracing across the full container startup path,
4-
including spans that originate inside the VM.
3+
Nerdbox supports distributed tracing across the full container startup path,
4+
including spans that originate inside the VM. Traces are exported via
5+
OTLP/HTTP (JSON) to any compatible collector (e.g., Jaeger).
56

67
## Tracing with Jaeger
78

@@ -28,19 +29,18 @@ gantt
2829
title Trace for nerdbox-vm
2930
3031
section VM.NewInstance+Start
31-
nerdbox/VM.NewInstance+Start :VM_NewInstance+Start_9f6fda, 0, 83
32-
. nerdbox/libkrun.VMStart :libkrun_VMStart_90885a, 5, 82
33-
. nerdbox/libkrun.WaitForTTRPC :libkrun_WaitForTTRPC_10af7c, 5, 82
34-
. nerdbox/TTRPC.Task.Create :TTRPC_Task_Create_5e832c, 83, 85
35-
. . nerdbox/containerd.task.v3.Task/Create :containerd_task_v3_Task_Create_3a4175, 84, 85
36-
. . . containerd.task.v3.Task/Create :containerd_task_v3_Task_Create_61f5b3, 83, 85
37-
. . . . task.Create :task_Create_a0b789, 84, 85
38-
. . . . . runc.NewContainer :runc_NewContainer_f4a190, 84, 85
39-
. . . . . . crun.create :crun_create_beaf4f, 84, 85
40-
. nerdbox/TTRPC.Task.Start :TTRPC_Task_Start_c8de57, 85, 87
41-
. . nerdbox/containerd.task.v3.Task/Start :containerd_task_v3_Task_Start_f0139b, 85, 87
42-
. . . containerd.task.v3.Task/Start :containerd_task_v3_Task_Start_1d5297, 85, 87
43-
. . . . task.Start :task_Start_84961b, 85, 87
44-
. . . . . . container.Start :container_Start_5372d6, 85, 87
45-
. . . . . . . crun.start :crun_start_ce160c, 85, 87
32+
nerdbox/VM.NewInstance+Start :VM_NewInstance+Start_6f2822, 0, 76
33+
. nerdbox/libkrun.VMStart :libkrun_VMStart_ae5193, 5, 76
34+
. nerdbox/TTRPC.Task.Create :TTRPC_Task_Create_902d0f, 77, 93
35+
. . nerdbox//containerd.task.v3.Task/Create :_containerd_task_v3_Task_Create_16dfce, 77, 93
36+
. . . /containerd.task.v3.Task/Create :_containerd_task_v3_Task_Create_71056a, 77, 80
37+
. . . . task.Create :task_Create_451e10, 77, 80
38+
. . . . . runc.NewContainer :runc_NewContainer_52991d, 77, 80
39+
. . . . . . crun.create :crun_create_d919ef, 77, 80
40+
. nerdbox/TTRPC.Task.Start :TTRPC_Task_Start_9e039e, 93, 95
41+
. . nerdbox//containerd.task.v3.Task/Start :_containerd_task_v3_Task_Start_b248bf, 93, 95
42+
. . . /containerd.task.v3.Task/Start :_containerd_task_v3_Task_Start_55073e, 93, 95
43+
. . . . task.Start :task_Start_f96cf6, 93, 95
44+
. . . . . container.Start :container_Start_f896e9, 93, 95
45+
. . . . . . crun.start :crun_start_9680f1, 93, 95
4646
```

internal/tracing/otlp.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package tracing
22

3-
import "encoding/hex"
4-
53
// OTLP JSON types for ExportTraceServiceRequest.
64
// See https://opentelemetry.io/docs/specs/otlp/#json-protobuf-encoding
75

@@ -47,7 +45,3 @@ type otlpKeyValue struct {
4745
type otlpAnyValue struct {
4846
StringValue string `json:"stringValue"`
4947
}
50-
51-
func hexEncode(b []byte) string {
52-
return hex.EncodeToString(b)
53-
}

0 commit comments

Comments
 (0)