Commit 6733936
committed
fix: use logs instead of start -a for tty container in TestCreateWithTty
With -t, the container's output goes through a pseudoTTY. Attaching
via "start -a" does not reliably forward PTY output through Tigron's
subprocess pipe, causing the stty check to fail on certain containerd
versions (e.g. v1.7.30).
Match the original test's approach: start the container without -a,
then read its output via "nerdctl logs" which goes through the log
driver and is always available after the container exits.
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>1 parent b8cc2ac commit 6733936
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
291 | 295 | | |
292 | 296 | | |
293 | 297 | | |
294 | 298 | | |
295 | 299 | | |
296 | | - | |
| 300 | + | |
297 | 301 | | |
298 | 302 | | |
299 | 303 | | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
| 304 | + | |
305 | 305 | | |
306 | 306 | | |
307 | 307 | | |
| |||
0 commit comments