Skip to content

fix: fix open ptmx fd twice #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxpv merged 1 commit into from
Apr 16, 2026
Merged

fix: fix open ptmx fd twice #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions crates/runc-shim/src/runc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,10 +609,7 @@ async fn copy_console(
let f = unsafe { File::from_raw_fd(fd.into_raw_fd()) };
if !stdio.stdin.is_empty() {
debug!("copy_console: pipe stdin to console");
let console_stdin = f
.try_clone()
.await
.map_err(io_error!(e, "failed to clone console file"))?;
let console_stdin = unsafe { tokio::fs::File::from_raw_fd(f.as_raw_fd()) };
let stdin = handle_file_open(|| async {
OpenOptions::new()
.read(true)
Expand All @@ -625,10 +622,7 @@ async fn copy_console(
}

if !stdio.stdout.is_empty() {
let console_stdout = f
.try_clone()
.await
.map_err(io_error!(e, "failed to clone console file"))?;
let console_stdout = unsafe { tokio::fs::File::from_raw_fd(f.as_raw_fd()) };
debug!("copy_console: pipe stdout from console");
let stdout = OpenOptions::new()
.write(true)
Expand Down
Loading