improve script

Author: gi8lino

Dockerfile

@@ -1,10 +1,10 @@
-FROM ghcr.io/containeroo/alpine-toolbox:2.7.11
+FROM ghcr.io/containeroo/alpine-toolbox:2.8.5
 
 # renovate: datasource=github-tags depName=minio/mc extractVersion=^RELEASE\\.(?<major>\\d+)-(?<minor>\\d+)-(?<patch>\\d+)T.*Z(-(?<compatibility>.*))?$
 ARG MINIO_VERSION=RELEASE.2023-10-14T01-57-03Z
 
-RUN wget -O /usr/local/bin/mc https://dl.min.io/client/mc/release/linux-amd64/mc && \
-  chmod +x /usr/local/bin/mc
+RUN wget -O /work/mc https://dl.min.io/client/mc/release/linux-amd64/mc && \
+  chmod +x /work/mc
 
 ADD mirrio.sh /mirrio.sh
 

mirrio.sh

@@ -1,22 +1,24 @@
 #!/usr/bin/env bash
-
 set -o errexit
+set -o pipefail
 
 JOB_NAME=${JOB_NAME:-mirrIO}
 RETENTION=${RETENTION:-30d0h0m}
 ADDITIONAL_PARAMETERS=${ADDITIONAL_PARAMETERS:---quiet}
+MC_BINARY=${MC_BINARY:-/work/mc}
 
-function pushgateway {
+pushgateway() {
   if [[ -n "${PUSHGATEWAY_URL}" ]]; then
-    cat <<-EOF | curl --retry 3 --max-time 5 --silent --show-error --data-binary @- "${PUSHGATEWAY_URL}/metrics/job/mirrio/instance/${JOB_NAME}" >/dev/null
-			# TYPE mirrio_sync_failed gauge
-			# HELP mirrio_sync_failed Whether the last sync failed
-			mirrio_sync_failed $1
-		EOF
+    cat <<-EOF | curl --retry 3 --max-time 5 --silent --show-error \
+      --data-binary @- "${PUSHGATEWAY_URL}/metrics/job/mirrio/instance/${JOB_NAME}" >/dev/null
+      # TYPE mirrio_sync_failed gauge
+      # HELP mirrio_sync_failed Whether the last sync failed
+      mirrio_sync_failed $1
+EOF
   fi
 }
 
-function check_env {
+check_env() {
   for var in "$@"; do
     if [[ -z "${!var}" ]]; then
       echo "${var} is not set!"
@@ -25,7 +27,7 @@ function check_env {
   done
 }
 
-function notify {
+notify() {
   pushgateway 1
   echo "ERROR: Unable to sync!"
 }
@@ -42,14 +44,22 @@ check_env \
 
 trap notify ERR
 
-mc alias set source "${SOURCE_URL}" "${SOURCE_ACCESSKEY}" "${SOURCE_SECRETKEY}" --api S3v4
+# Split extra parameters into an array so multiple flags work
+# shellcheck disable=SC2206
+read -r -a MC_ARGS <<<"${ADDITIONAL_PARAMETERS}"
 
-mc alias set destination "${DESTINATION_URL}" "${DESTINATION_ACCESSKEY}" "${DESTINATION_SECRETKEY}" --api S3v4
+"$MC_BINARY" alias set source "${SOURCE_URL}" "${SOURCE_ACCESSKEY}" "${SOURCE_SECRETKEY}" --api S3v4
+"$MC_BINARY" alias set destination "${DESTINATION_URL}" "${DESTINATION_ACCESSKEY}" "${DESTINATION_SECRETKEY}" --api S3v4
 
-mc ls destination | grep -q "${DESTINATION_BUCKET}" || mc mb "destination/${DESTINATION_BUCKET}"
+# Create destination bucket if missing (ignore if it already exists)
+"$MC_BINARY" mb --ignore-existing "destination/${DESTINATION_BUCKET}"
 
-[[ -n $(mc ls "source/${SOURCE_BUCKET}") ]] && mc rm --force --recursive --dangerous --older-than "${RETENTION}" "source/${SOURCE_BUCKET}"
+# Optional retention cleanup on SOURCE (only if bucket exists)
+if "$MC_BINARY" ls "source/${SOURCE_BUCKET}" >/dev/null 2>&1; then
+  "$MC_BINARY" rm --force --recursive --dangerous --older-than "${RETENTION}" "source/${SOURCE_BUCKET}"
+fi
 
-mc mirror --remove "${ADDITIONAL_PARAMETERS}" "source/${SOURCE_BUCKET}" "destination/${DESTINATION_BUCKET}"
+# Mirror with remove + any additional flags
+"$MC_BINARY" mirror --remove "${MC_ARGS[@]}" "source/${SOURCE_BUCKET}" "destination/${DESTINATION_BUCKET}"
 
 pushgateway 0