common: add ssh.ExecWithOutput to allow streaming output#865
Open
danishprakash wants to merge 1 commit into
Open
common: add ssh.ExecWithOutput to allow streaming output#865danishprakash wants to merge 1 commit into
danishprakash wants to merge 1 commit into
Conversation
Follow-up to 2681204 that added ExecWithInput allowing executing commands over ssh while passing an optional input reader. For cases where remote > local output needs to be streamed, add a similar ExecWithOutput that returns a ReadCloser. Signed-off-by: Danish Prakash <contact@danishpraka.sh>
Contributor
|
Thanks! (I didn’t read the code ~at all.) Is there an expected user in the Podman ecosystem? |
Member
Author
|
Ah, yes, I should've mentioned this, but this is a requirement for implementing support for containers/podman#28321. For supporting *-dir formats between remote to local/remote ie "save image on remote host and stream it back". I'm yet to raise the PR on podman, which uses this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 2681204 that added ExecWithInput, allowing executing commands over SSH while passing an optional input reader. For cases where remote > local output needs to be streamed, add a similar ExecWithOutput that returns a ReadCloser.