Merge pull request #2109 from leonardomoreira00/bug/fix-oom-systemd-annotation

giuseppe · web-flow · commit d17fd8701992 · 2026-06-22T13:30:42.000+02:00
cgroup: fix memory issue when resizing array of strings
diff --git a/src/libcrun/cgroup-systemd.c b/src/libcrun/cgroup-systemd.c
@@ -671,7 +671,7 @@ append_systemd_annotation (sd_bus_message *m, const char *name, size_t name_len,
           if (n_parts == parts_size - 1)
             {
               parts_size += 32;
-              parts = xrealloc (parts, parts_size);
+              parts = xrealloc (parts, sizeof (char *) * parts_size);
             }
           parts[n_parts] = NULL;
           if (next == NULL)

Original file line number	Diff line number	Diff line change
`@@ -671,7 +671,7 @@ append_systemd_annotation (sd_bus_message m, const char name, size_t name_len,`
`671`	`671`	`if (n_parts == parts_size - 1)`
`672`	`672`	`{`
`673`	`673`	`parts_size += 32;`
`674`		`- parts = xrealloc (parts, parts_size);`
	`674`	`+ parts = xrealloc (parts, sizeof (char ) parts_size);`
`675`	`675`	`}`
`676`	`676`	`parts[n_parts] = NULL;`
`677`	`677`	`if (next == NULL)`