test(core): add fake kube dynamic client; add Core resources testing …#1042
Open
difrost wants to merge 2 commits into
Open
test(core): add fake kube dynamic client; add Core resources testing …#1042difrost wants to merge 2 commits into
difrost wants to merge 2 commits into
Conversation
…using fake client Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
matzew
reviewed
Apr 14, 2026
|
|
||
| result, err := core.ResourcesScale(ctx(), &schema.GroupVersionKind{ | ||
| Group: "apps", Version: "v1", Kind: "Deployment", | ||
| }, "default", "my-deploy", 0, false) |
Collaborator
There was a problem hiding this comment.
desiredScale=0 and shouldScale=false means that update/write is not tested
Contributor
Author
There was a problem hiding this comment.
The test was correct - intended check with shouldScale=false. Updated with missing parts: 1e9551c
…ath test Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
k8s.io/client-go/dynamic/fake.FakeDynamicClient;kubernetes.Interfacethat embeds thek8s.io/client-go/kubernetes/fake.Clientset;Reset()RESTMapper()pre-configured with GVR->GVK mappings;DiscoveryClient()- fake clientset's discovery wrapped inmemory.NewMemCacheClient, withAPIResourcespopulated to match registered GVRs;ResourcesGet,ResourcesList,ResourcesDelete,ResourcesScaleandResourcesCreateOrUpdate.The dryRun feature that is proposed under #1026 can't be tested as fake client - currently - ignores opts.
Note: To avoid importing type packages (and use an empty scheme) this is using
fake.NewSimpleDynamicClientWithCustomListKindsinstead offake.NewSimpleDynamicClient.