feat(core): Add fieldSelector to events_list and namespaces_list tools#1138
Open
difrost wants to merge 5 commits into
Open
feat(core): Add fieldSelector to events_list and namespaces_list tools#1138difrost wants to merge 5 commits into
difrost wants to merge 5 commits into
Conversation
Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
Collaborator
|
Consider adding a unit test for |
…Selector Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
Contributor
Author
matzew
reviewed
May 12, 2026
| @@ -0,0 +1,2 @@ | |||
| #!/usr/bin/env bash | |||
| kubectl delete namespace event-filter-test --ignore-not-found | |||
Collaborator
There was a problem hiding this comment.
should it be events-filter-test ?
Contributor
Author
Signed-off-by: Jacek Luczak <difrost.kernel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
fieldSelectorproperty toevents_listandnamespaces_listin a similar fashion how it's defined for e.g.pods_list.The biggest added values is for the
events_listwhere a tool call on a busy namespace with a lot of events generated is killing most of the agents.I've also added evals for both tool extensions but can't figure a better way than just verifying with llmJudge
contains.@Cali0707 / @manusa please review.