test/system: Fix 260-sdnotify being silently skipped#28448
Merged
Conversation
PODMAN_CMD is uninitialized until basic_setup() runs, causing podman_runtime() to invoke an empty command and fall back to [null]. Call basic_setup() before the runtime check to ensure PODMAN_CMD is populated before use. Signed-off-by: Ricardo Branco <rbranco@suse.de>
Contributor
Author
danishprakash
approved these changes
Apr 6, 2026
lsm5
approved these changes
Apr 6, 2026
Member
lsm5
left a comment
There was a problem hiding this comment.
LGTM
@containers/podman-maintainers PTAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 260-sdnotify being silently skipped since podman v5.7.1
PODMAN_CMD is uninitialized until basic_setup() runs, causing podman_runtime() to invoke an empty command and fall back to [null].
Call basic_setup() before the runtime check to ensure PODMAN_CMD is populated before use.
Otherwise all the tests are silently skipped:
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?