Skip to content

test/system: Fix 260-sdnotify being silently skipped#28448

Merged
baude merged 1 commit into
containers:mainfrom
ricardobranco777:fixnullruntime
Apr 6, 2026
Merged

test/system: Fix 260-sdnotify being silently skipped#28448
baude merged 1 commit into
containers:mainfrom
ricardobranco777:fixnullruntime

Conversation

@ricardobranco777
Copy link
Copy Markdown
Contributor

@ricardobranco777 ricardobranco777 commented Apr 5, 2026

Fix 260-sdnotify being silently skipped since podman v5.7.1

PODMAN_CMD is uninitialized until basic_setup() runs, causing podman_runtime() to invoke an empty command and fall back to [null].

Call basic_setup() before the runtime check to ensure PODMAN_CMD is populated before use.

Otherwise all the tests are silently skipped:

ok 507 sdnotify : ignore # skip this test only works with crun, not [null]
ok 508 sdnotify : conmon # skip this test only works with crun, not [null]
ok 509 sdnotify : container # skip this test only works with crun, not [null]
ok 510 sdnotify : healthy # skip this test only works with crun, not [null]
ok 511 sdnotify : play kube - no policies # skip this test only works with crun, not [null]
ok 512 sdnotify : play kube - with policies # skip this test only works with crun, not [null]
ok 513 podman kube play - exit-code propagation # skip this test only works with crun, not [null]
ok 514 podman pull - EXTEND_TIMEOUT_USEC # skip this test only works with crun, not [null]
ok 515 podman system service # skip this test only works with crun, not [null]

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

PODMAN_CMD is uninitialized until basic_setup() runs, causing
podman_runtime() to invoke an empty command and fall back to [null].

Call basic_setup() before the runtime check to ensure PODMAN_CMD is
populated before use.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
@ricardobranco777
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@containers/podman-maintainers PTAL

Copy link
Copy Markdown
Member

@baude baude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baude baude merged commit f1eb69b into containers:main Apr 6, 2026
58 checks passed
@ricardobranco777 ricardobranco777 deleted the fixnullruntime branch April 6, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants