Upgrade to new license specifications.#2399
Conversation
Summary of ChangesHello @jwieleRH, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the project's license specification in pyproject.toml to align with the latest standards from setuptools (version 77.0.0 and newer). The changes include adopting the SPDX license expression in the [project] table, removing the deprecated [project.license] table and the redundant License classifier, and cleaning up the [tool.setuptools] section. The required setuptools version is also appropriately updated. The changes are clear, well-motivated, and correctly implemented. I have no further suggestions for improvement.
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools"] | |||
| requires = ["setuptools>=77.0.0"] | |||
There was a problem hiding this comment.
Will this cause issues for installing on RHEL9?
There was a problem hiding this comment.
Was just about to ask that...
There are other issues to address for el9 though. If this works on el10 I think we could patch it for rpm builds on el9.
Is this deprecated and scheduled for removal, or just a deprecated warning?
There was a problem hiding this comment.
Does not work on el10:
No matching package to install: 'python3dist(setuptools) >= 77'
Not all dependencies satisfied
Error: Some packages could not be found.
There was a problem hiding this comment.
PRETTY_NAME="Red Hat Enterprise Linux 9.7 (Plow)"
ERROR: Package 'ramalama' requires a different Python: 3.9.25 not in '>=3.10'
RHEL9.7 appears to have Python 3.9.25 while RamaLama requires Python 3.10 so that ship may have sailed.
There was a problem hiding this comment.
You can install Python3.11 I believe on RHEL.
There was a problem hiding this comment.
You can install Python3.11 I believe on RHEL.
on el9? yes, 3.12 rpm is available too. However in both cases the dependencies we require are not packaged (nor are they in EPEL)
There was a problem hiding this comment.
Well Red Hat really needs RamaLama to work on RHEL10, and would be nice to work on RHEL9, if there is a way to hack around this in the Spec file, then I am fine with the change.
|
From the log of "make pypi-build": |
|
That's next year
…On Tue 10 Feb 2026, 16:47 John Wiele, ***@***.***> wrote:
*jwieleRH* left a comment (containers/ramalama#2399)
<#2399 (comment)>
From the log of "make pypi-build":
Please use a simple string containing a SPDX expression for
project.license. You can also use project.license-files. (Both options
available on setuptools>=77.0.0).
By 2027-Feb-18, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
—
Reply to this email directly, view it on GitHub
<#2399 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB2UDA5OEFRDOG5DJK6JOL4LIDP3AVCNFSM6AAAAACUDG4D66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZYHE3TGMBXGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
In the meantime let's just watch pypa/setuptools#4903 |
project.license as a TOML table is deprecated. The new license representation is project.license, a valid SPDX license expression consisting of one or more license identifiers and project.license-files, a list of license files. See: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license. Remove License classifier: License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/). PyPI.org still recognizes license classifiers as search terms, but tools that enforce compliance with PEP-639 balk. Remove [tool.setuptools] license-files. It is redundant. Signed-off-by: John Wiele <jwiele@redhat.com>
As of setuptools version 77.0.0, project.license as a TOML table is deprecated. The new license representation is project.license, a valid SPDX license expression consisting of one or more license identifiers and project.license-files, a list of license files. See: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license.
Remove License classifier: License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/). PyPI.org still recognizes license classifiers as search terms, but tools that enforce compliance with PEP-639 balk.
Remove [tool.setuptools] license-files. It is redundant.