Test: make generated client use the PW requests #1453
Open
dominikvagner wants to merge 3 commits into
Open
Conversation
This fixes an issue with a wrong describe used in `auth.setup.ts`, changes the project name of API tests to something appropriate and quiets unnecessary logs.
This fixes incorrect docs and makes the interval longer as 10 ms was way too spammy.
This changes the way how the generated typescript client, we use for testing, sends the requests. Previously we used the default or undici for this, but that meant we couldn't see those requests in the PW traces, making it hard to debug. We can utilize the built-in Playwright request fixture and API context to do this, by providing a custom "FetchAPI" to the generated client. Also makes the client dynamically pick-up fresh credentials per request by default.
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
katarinazaprazna
approved these changes
Apr 10, 2026
Contributor
katarinazaprazna
left a comment
katarinazaprazna
left a comment
There was a problem hiding this comment.
Thanks for the changes! This is super helpful. Nice work 🙌
Contributor
|
@dominikvagner did you wanna merge this? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the way how the generated typescript client, we use for
testing, sends the requests. Previously we used the default or undici
for this, but that meant we couldn't see those requests in the PW
traces, making it hard to debug.
We can utilize the built-in Playwright request fixture and API context
to do this, by providing a custom "FetchAPI" to the generated client.
Also makes the client dynamically pick-up fresh credentials per request
by default.
And makes a few smaller tweaks in the first 2 commits:
Testing steps
All tests pass and the network logs in Playwright traces display the requests made by the client.