Test: remove no longer needed custom configs#962
Open
dominikvagner wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that the dynamic API client is injected via the
clientfixture, consider encapsulating the remainingensureValidToken(..., '<TOKEN>.json', ...)+ API call patterns (e.g., the polling block inCanUpdateSystemWithTemplate) into a small helper so token file names and validity checks aren’t duplicated and stay consistent across tests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that the dynamic API client is injected via the `client` fixture, consider encapsulating the remaining `ensureValidToken(..., '<TOKEN>.json', ...)` + API call patterns (e.g., the polling block in `CanUpdateSystemWithTemplate`) into a small helper so token file names and validity checks aren’t duplicated and stay consistent across tests.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
These custom dynamic configs aren't going to be needed after client changes done in "test-utils", they will be dynamic by default.
dominikvagner
force-pushed
the
ts-client-playwright-network-logs
branch
from
c3a8d86 to
aadf5f6
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
CanUpdateSystemWithTemplate.spec.ts, now that the sharedclientis used for API calls, consider encapsulating or removing the explicitensureValidToken(page, 'LAYERED_REPO_TOKEN.json', 5)in the polling step to avoid duplicated token-handling logic between the client fixture and the tests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `CanUpdateSystemWithTemplate.spec.ts`, now that the shared `client` is used for API calls, consider encapsulating or removing the explicit `ensureValidToken(page, 'LAYERED_REPO_TOKEN.json', 5)` in the polling step to avoid duplicated token-handling logic between the client fixture and the tests.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
katarinazaprazna
approved these changes
Apr 13, 2026
Contributor
katarinazaprazna
left a comment
katarinazaprazna
left a comment
There was a problem hiding this comment.
Looks great! The code feels a lot cleaner now. Thanks! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This will need to update the test-utils ref and merge that together, with those changes!
Summary
These custom dynamic configs aren't going to be needed after client changes done in "test-utils", they will be dynamic by default.
Testing steps
All tests pass.
#testwith content-services/content-sources-backend#1453