fix: parse PEM cert chain to DER in RemoteSigner construction#2075
Open
trufo-ai wants to merge 1 commit into
Open
fix: parse PEM cert chain to DER in RemoteSigner construction#2075trufo-ai wants to merge 1 commit into
trufo-ai wants to merge 1 commit into
Conversation
The Remote variant of SignerSettings::c2pa_signer() was passing the raw PEM string bytes as a single cert blob, rather than parsing individual PEM certificates into DER. This caused two issues: 1. certs contained raw PEM text instead of DER-encoded certificates 2. reserve_size was based on PEM text length rather than DER cert sizes Parse the PEM cert chain with pem::parse_many() to extract individual DER-encoded certificates, matching the behavior of the Local variant which uses create_signer::from_keys() for proper PEM handling.
Author
|
need to sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Remote variant of SignerSettings::c2pa_signer() was passing the raw PEM string bytes as a single cert blob, rather than parsing individual PEM certificates into DER. This caused two issues:
Parse the PEM cert chain with pem::parse_many() to extract individual DER-encoded certificates, matching the behavior of the Local variant which uses create_signer::from_keys() for proper PEM handling.
Changes in this pull request
Give a narrative description of what has been changed.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.