Skip to content

Add advanced GA4 matching and reviewer validation guide []#10881

Open
zacharyyankiver wants to merge 8 commits intomasterfrom
codex/ga4-advanced-matching-master-pr
Open

Add advanced GA4 matching and reviewer validation guide []#10881
zacharyyankiver wants to merge 8 commits intomasterfrom
codex/ga4-advanced-matching-master-pr

Conversation

@zacharyyankiver
Copy link
Copy Markdown
Contributor

Summary

  • add advanced GA4 matching support for query strings, flexible patterns, multiple rules per content type, and multiple page properties per rule
  • expand the sidebar with new date range options, custom range selection, unique views, and clearer multi-rule summaries
  • add a reviewer-facing validation guide with local test-site, Contentful fixture, and app configuration instructions

Validation

  • cd apps/apps/google-analytics-4/frontend && npm run build
  • cd apps/apps/google-analytics-4/lambda && npm run build
  • cd apps/apps/google-analytics-4/frontend && npm run test:ci -- src/hooks/useSidebarRules/useSidebarRules.spec.tsx src/components/main-app/ChartContent/ChartContent.spec.tsx src/components/main-app/AnalyticsMetricDisplays/AnalyticsMetricDisplay.spec.tsx src/components/main-app/ChartHeader/ChartHeader.spec.tsx src/components/config-screen/assign-content-type/AssignContentTypeRow.spec.tsx src/components/config-screen/assign-content-type/AssignContentTypeCard.spec.tsx src/components/config-screen/assign-content-type/AssignContentTypeSection.spec.tsx src/components/main-app/ChartFooter/ChartFooter.spec.tsx src/helpers/DateRangeHelpers/DateRangeHelpers.spec.ts src/apis/api.spec.ts src/utils/getReportSlug.spec.ts

Reviewer Notes

  • see apps/google-analytics-4/VALIDATION.md for step-by-step setup and validation instructions
  • the validation guide intentionally does not include the raw service-account private key; reviewers should use their own GA4 service-account JSON or obtain the shared JSON through a secure channel

@zacharyyankiver zacharyyankiver requested review from a team as code owners April 16, 2026 17:52
@wiz-inc-38d59fb8d7
Copy link
Copy Markdown

wiz-inc-38d59fb8d7 Bot commented Apr 16, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 3 Medium 3 Low
Software Management Finding Software Management Findings -
Total 3 Medium 3 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@zacharyyankiver zacharyyankiver changed the title Add advanced GA4 matching and reviewer validation guide Add advanced GA4 matching and reviewer validation guide [] Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant