Refactor DefaultRetryPolicy and improve status code handling in RetryDelayCalculator

reeshika-h · reeshika-h · commit d426b9671a3f · 2026-01-07T14:41:08.000+05:30
diff --git a/Contentstack.Management.Core/Runtime/Pipeline/RetryHandler/DefaultRetryPolicy.cs b/Contentstack.Management.Core/Runtime/Pipeline/RetryHandler/DefaultRetryPolicy.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Net;
 using System.Net.Http;
-using System.Net.Http.Headers;
 using Contentstack.Management.Core.Exceptions;
 using Contentstack.Management.Core.Runtime.Contexts;
 
@@ -208,11 +207,6 @@ public TimeSpan GetNetworkRetryDelay(IRequestContext requestContext)
                 requestContext.NetworkRetryCount,
                 retryConfiguration);
         }
-
-        // Internal methods for testing
-        internal bool CanRetryInternal(IExecutionContext executionContext) => CanRetry(executionContext);
-        internal bool RetryForExceptionInternal(IExecutionContext executionContext, Exception exception) => RetryForException(executionContext, exception);
-        internal bool RetryLimitExceededInternal(IExecutionContext executionContext) => RetryLimitExceeded(executionContext);
     }
 }
 
diff --git a/Contentstack.Management.Core/Runtime/Pipeline/RetryHandler/RetryDelayCalculator.cs b/Contentstack.Management.Core/Runtime/Pipeline/RetryHandler/RetryDelayCalculator.cs
@@ -111,7 +111,7 @@ public bool ShouldRetryHttpStatusCode(HttpStatusCode statusCode, RetryConfigurat
             }
 
             // Default retry condition: 429, 500, 502, 503, 504
-            return statusCode == (HttpStatusCode)429 || // TooManyRequests
+            return statusCode == HttpStatusCode.TooManyRequests || // TooManyRequests
                    statusCode == HttpStatusCode.InternalServerError ||
                    statusCode == HttpStatusCode.BadGateway ||
                    statusCode == HttpStatusCode.ServiceUnavailable ||
diff --git a/Contentstack.Management.Core/contentstack.management.core.csproj b/Contentstack.Management.Core/contentstack.management.core.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net471;net472;</TargetFrameworks>
-    <LangVersion>8.0</LangVersion>
     <Title>Contentstack Management</Title>
     <Authors>Contentstack</Authors>
     <Copyright>Copyright © 2012-2025 Contentstack. All Rights Reserved</Copyright>

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.Net;`
`4`	`4`	`using System.Net.Http;`
`5`		`-using System.Net.Http.Headers;`
`6`	`5`	`using Contentstack.Management.Core.Exceptions;`
`7`	`6`	`using Contentstack.Management.Core.Runtime.Contexts;`
`8`	`7`
`@@ -208,11 +207,6 @@ public TimeSpan GetNetworkRetryDelay(IRequestContext requestContext)`
`208`	`207`	`requestContext.NetworkRetryCount,`
`209`	`208`	`retryConfiguration);`
`210`	`209`	`}`
`211`		`-`
`212`		`- // Internal methods for testing`
`213`		`- internal bool CanRetryInternal(IExecutionContext executionContext) => CanRetry(executionContext);`
`214`		`- internal bool RetryForExceptionInternal(IExecutionContext executionContext, Exception exception) => RetryForException(executionContext, exception);`
`215`		`- internal bool RetryLimitExceededInternal(IExecutionContext executionContext) => RetryLimitExceeded(executionContext);`
`216`	`210`	`}`
`217`	`211`	`}`
`218`	`212`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public bool ShouldRetryHttpStatusCode(HttpStatusCode statusCode, RetryConfigurat`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`// Default retry condition: 429, 500, 502, 503, 504`
`114`		`- return statusCode == (HttpStatusCode)429 \|\| // TooManyRequests`
	`114`	`+ return statusCode == HttpStatusCode.TooManyRequests \|\| // TooManyRequests`
`115`	`115`	`statusCode == HttpStatusCode.InternalServerError \|\|`
`116`	`116`	`statusCode == HttpStatusCode.BadGateway \|\|`
`117`	`117`	`statusCode == HttpStatusCode.ServiceUnavailable \|\|`