fix(5633): correct Enable endpoint; stabilize workflow integration tests#152
Open
OMpawar-21 wants to merge 4 commits intodevelopmentfrom
Open
fix(5633): correct Enable endpoint; stabilize workflow integration tests#152OMpawar-21 wants to merge 4 commits intodevelopmentfrom
OMpawar-21 wants to merge 4 commits intodevelopmentfrom
Conversation
…ases Add Contentstack018_EnvironmentTest.cs with complete CRUD coverage for Environment API. - 16 tests: sync/async happy path + negative path scenarios - Fix API calls to use environment names instead of UIDs for fetch/update/delete - Includes proper cleanup, unique naming, and error handling - All tests passing with comprehensive positive/negative validation
Add Contentstack019_RoleTest with 16 integration tests (sync/async CRUD + query,
negative paths for non-existent role UID). Roles use /roles/{uid}; minimal
RoleModel uses BranchRules for branch main. Mirrors Contentstack018 patterns.
Add EntryVariant model and Entry.Variant() for create/fetch/find/update/delete against entry variant endpoints. Extend publish flow with PublishVariant, PublishVariantRules, and serialization in PublishUnpublishDetails / PublishUnpublishService; update unit tests for variant publish JSON. Add Contentstack021_EntryVariantTest: Product Banner lifecycle (setup, create, fetch, publish, delete) with config-based stack API key, and negative cases for invalid entry/variant, publish, environments, and unlinked content types. Update CHANGELOG for Entry Variant support.
- Workflow.Enable() / EnableAsync() now call .../enable instead of .../disable. - Integration tests: resolve a real content-type UID for GetPublishRule (Test011); publish-rule update uses stack locales only (Test012); duplicate-name create handles ContentstackErrorException (Test103); delete-with-publish-rules expects success per API (Test108); post-delete fetch handles exception path (Test110).
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
cs-raj
previously approved these changes
Apr 7, 2026
OMpawar-21
dismissed
cs-raj’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow.Enable()/EnableAsync()calling the disable URL; both now use the/enablepath.Contentstack020_WorkflowTestwith real API behavior and stack constraints.Test changes
GetPublishRule(the API does not treat$allas a valid path segment for that endpoint).en-usonly).ContentstackErrorExceptionwhen the client throws on 422.Fetchhandles both response and exception paths.