-
Notifications
You must be signed in to change notification settings - Fork 1
fix: declare lxml as a runtime dependency (v1.6.1) #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,6 @@ | |
| __title__ = 'contentstack_utils' | ||
| __author__ = 'contentstack' | ||
| __status__ = 'debug' | ||
| __version__ = '1.6.0' | ||
| __version__ = '1.6.1' | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I just though that patch version bump is not ideal, and major release is better, because thought people had to install lxml already they could install any version of it, since the library didn't restrict it. Now it's restricted, so people may get conflicts? Shouldn't be that bad, but I leave the decision on you |
||
| __endpoint__ = 'cdn.contentstack.io' | ||
| __contact__ = 'support@contentstack.com' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,9 +34,11 @@ def run(self): | |
| long_description_content_type="text/markdown", | ||
| url="https://github.com/contentstack/contentstack-utils-python", | ||
| license='MIT', | ||
| version='1.6.0', | ||
| version='1.6.1', | ||
| install_requires=[ | ||
|
|
||
| # lxml 6.x requires Python 3.8+; keep 4.x for 3.6–3.7 (python_requires>=3.6). | ||
| "lxml>=4.9.0,<5; python_version<'3.8'", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may make sense to drop support for python <3.9 already since even 3.10 is eol this October https://devguide.python.org/versions/ |
||
| "lxml>=6.1.0; python_version>='3.8'", | ||
| ], | ||
| setup_requires=['pytest-runner'], | ||
| tests_require=['pytest==4.4.1'], | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The development branch is not up to the latest main, so this change is propagated, but is not mine