fix: retain empty strings value for alt attr for img and asset while conversion to html

Author: shreya-kamble

src/toRedactor.tsx

@@ -506,11 +506,15 @@ export const toRedactor = (jsonValue: any,options?:IJsonToHtmlOptions) : string
         delete attrsJson['url']
       }
       delete attrsJson['redactor-attributes']
-      Object.entries(attrsJson).forEach((key) => {
-        if (forbiddenAttrChars.some(char => key[0].includes(char))) {
+      Object.entries(attrsJson).forEach((item) => {
+        if (forbiddenAttrChars.some(char => item[0].includes(char))) {
           return; 
         }
-        return key[1] ? (key[1] !== '' ? (attrs += `${key[0]}="${replaceHtmlEntities(key[1])}" `) : '') : ''
+        if((jsonValue['type'] === 'img' || (jsonValue['type'] === 'reference') && jsonValue.attrs['display-type'] === 'display' ) && item[0] === 'alt'){
+          attrs += `${item[0]}="${replaceHtmlEntities(item[1])}" `
+          return;
+        }
+        return item[1] ? (item[1] !== '' ? (attrs += `${item[0]}="${replaceHtmlEntities(item[1])}" `) : '') : ''
       })
       attrs = (attrs.trim() ? ' ' : '') + attrs.trim()
     }

test/expectedJson.ts

@@ -2204,6 +2204,36 @@ export default {
 
         ]    
 
+    },
+    "RT-268":{
+        "html": `<img alt="" src="image_url.jpeg" width="100" style="width: 100; height: auto;" />`,
+        "json": 
+            {
+                "id": "a4794fb7214745a2a47fc24104b762f9",
+                "type": "docs",
+                "children": [
+                    {
+                        "type": "img",
+                        "attrs": {
+                            "url": "image_url.jpeg",
+                            "redactor-attributes": {
+                                "alt": "",
+                                "src": "image_url.jpeg",
+                                "width": "100"
+                            },
+                            "width": "100"
+                        },
+                        "uid": "18ff239605014dcaaa23c705caf99403",
+                        "children": [
+                            {
+                                "text": ""
+                            }
+                        ]
+                    }
+                ]
+            }
+            
+        
     }
 
 }

test/toRedactor.test.ts

@@ -3,6 +3,7 @@ import isEqual from "lodash.isequal"
 
 import expectedValue from "./expectedJson"
 import { imageAssetData } from "./testingData"
+import exp from "constants"
 
 describe("Testing json to html conversion", () => {
     it("heading conversion", () => {
@@ -292,5 +293,11 @@ describe("Testing json to html conversion", () => {
     const html = toRedactor(json);
     expect(html).toBe(`<img alt="Infographic showing 3 results from Forrester study of Contentstack CMS: $3M increase in profit, $507.3K productivity savings and $2.0M savings due to reduced time to publish." src="https://images.contentstack.io/v3/assets/blt7359e2a55efae483/bltea2a11144a2c68b5/63c08b7f438f80612c397994/CS_Infographics_ForresterReport_Data_3_1200x628_(1).png" position="center" width="641" style="width: 641; height: auto;" />`)
     })
+
+    test(' should retain empty string value for alt attribute', () => {
+       const json = expectedValue['RT-268'].json;
+       const html = toRedactor(json);
+       expect(html).toBe(expectedValue['RT-268'].html);
+    })
 })