Skip to content

Commit 12be298

Browse files
committed
fix: addresed the requested cahnges
1 parent 764fc0b commit 12be298

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

src/visualBuilder/components/FieldLocationIcon.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,22 @@ import React, { useRef } from "preact/compat";
66
import { LoadingIcon } from "./icons/loading";
77
import { VisualBuilderPostMessageEvents } from "../utils/types/postMessage.types";
88
import visualBuilderPostMessage from "../utils/visualBuilderPostMessage";
9+
import { CslpData } from "../../utils/cslpdata";
910

1011
export const FieldLocationIcon = ({
1112
fieldLocationData,
1213
multipleFieldToolbarButtonClasses,
1314
handleMoreIconClick,
1415
moreButtonRef,
1516
toolbarRef,
17+
domEditStack
1618
}: {
1719
fieldLocationData: any;
1820
multipleFieldToolbarButtonClasses: any;
1921
handleMoreIconClick: () => void;
2022
moreButtonRef: any;
2123
toolbarRef: any;
24+
domEditStack:CslpData[]
2225
}) => {
2326

2427

@@ -32,7 +35,7 @@ export const FieldLocationIcon = ({
3235
visualBuilderPostMessage?.send(VisualBuilderPostMessageEvents.FIELD_LOCATION_SELECTED_APP, {
3336
app,
3437
position: toolbarRef.current?.getBoundingClientRect(),
35-
DomEditStack:fieldLocationData.DomEditStack
38+
DomEditStack:domEditStack
3639
});
3740
};
3841

src/visualBuilder/components/FieldToolbar.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { CslpData } from "../../cslp/types/cslp.types";
2+
import { CslpData as CslpDataUtil } from "../../utils/cslpdata";
23
import getChildrenDirection from "../utils/getChildrenDirection";
34
import {
45
ALLOWED_MODAL_EDITABLE_FIELD,
@@ -195,6 +196,9 @@ function FieldToolbarComponent(
195196
// }
196197
}
197198

199+
const domEditStack=getDOMEditStack(eventDetails.editableElement) as CslpDataUtil[]
200+
201+
198202
const invertTooltipPosition =
199203
targetElement.getBoundingClientRect().top <= TOOLTIP_TOP_EDGE_BUFFER;
200204

@@ -570,6 +574,7 @@ function FieldToolbarComponent(
570574
handleMoreIconClick={handleMoreIconClick}
571575
moreButtonRef={moreButtonRef}
572576
toolbarRef={toolbarRef}
577+
domEditStack={domEditStack}
573578
/>
574579
</>
575580
</div>
@@ -579,7 +584,7 @@ function FieldToolbarComponent(
579584
toolbarRef={toolbarRef}
580585
apps={fieldLocationData?.apps || ([] as any[])}
581586
position={appListPosition}
582-
domEditStack={fieldLocationData.DomEditStack}
587+
domEditStack={domEditStack}
583588
setDisplayAllApps={setDisplayAllApps}
584589
displayAllApps={displayAllApps}
585590
/>

0 commit comments

Comments
 (0)