Skip to content

Commit 2a29a81

Browse files
committed
fix(VE-5139): fix test cases
1 parent 89ca3d8 commit 2a29a81

2 files changed

Lines changed: 14 additions & 8 deletions

File tree

src/visualBuilder/utils/__test__/handleIndividualFields.test.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,18 @@ describe("cleanIndividualFieldResidual", () => {
153153
expect(elements.resizeObserver.unobserve).toHaveBeenCalledWith(pseudoEditableElement);
154154
expect(pseudoEditableElement.parentNode).toBeNull();
155155
});
156-
157-
it("should clean focused toolbar correctly", () => {
158-
cleanIndividualFieldResidual(elements);
159-
160-
expect(elements.focusedToolbar?.innerHTML).toBe("");
161-
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(VisualBuilderPostMessageEvents.DELETE_INSTANCE);
162-
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID);
156+
it("should clean focused toolbar correctly", () => {
157+
cleanIndividualFieldResidual(elements);
158+
159+
expect(elements.focusedToolbar?.innerHTML).toBe("");
160+
161+
const toolbarEvents = [VisualBuilderPostMessageEvents.DELETE_INSTANCE, VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID];
162+
toolbarEvents.forEach((event) => {
163+
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
164+
if (visualBuilderPostMessage?.requestMessageHandlers?.has(event)) {
165+
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
166+
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(event);
167+
}
163168
});
169+
});
164170
});

src/visualBuilder/utils/handleIndividualFields.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ export function cleanIndividualFieldResidual(elements: {
298298
const toolbarEvents = [VisualBuilderPostMessageEvents.DELETE_INSTANCE, VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID]
299299
toolbarEvents.forEach((event) => {
300300
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
301-
if (visualBuilderPostMessage.requestMessageHandlers.has(event)) {
301+
if (visualBuilderPostMessage?.requestMessageHandlers?.has(event)) {
302302
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
303303
visualBuilderPostMessage?.unregisterEvent?.(event);
304304
}

0 commit comments

Comments
 (0)